From: Takashi Iwai Subject: Re: [PATCH] ASoC: Intel: fix machine driver warnings Date: Fri, 06 Feb 2015 08:46:43 +0100 Message-ID: References: <1423181956-108810-1-git-send-email-yang.a.fang@intel.com> <0485FB02182A4744A8B06D69AB7BF8E718BF49B0@ORSMSX113.amr.corp.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 19E2C260564 for ; Fri, 6 Feb 2015 08:46:44 +0100 (CET) In-Reply-To: <0485FB02182A4744A8B06D69AB7BF8E718BF49B0@ORSMSX113.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Fang, Yang A" Cc: "alsa-devel@alsa-project.org" , "N, Harshapriya" , "Jain, Praveen K" , "lgirdwood@gmail.com" , "Strasser, Kevin" , "Iriawan, Denny" , "broonie@kernel.org" , "Lin, Mengdong" , "Koul, Vinod" List-Id: alsa-devel@alsa-project.org At Fri, 6 Feb 2015 07:42:03 +0000, Fang, Yang A wrote: > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Thursday, February 05, 2015 11:23 PM > > To: Fang, Yang A > > Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org; > > Iriawan, Denny; N, Harshapriya; Jain, Praveen K; Strasser, Kevin; Koul, Vinod; > > Lin, Mengdong > > Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix machine driver warnings > > > > At Thu, 5 Feb 2015 16:19:16 -0800, > > yang.a.fang@intel.com wrote: > > > > > > From: "Fang, Yang A" > > > > > > this patch will fix below sparse warnings > > > > > > warning: incorrect type in argument 2 (different base types) expected > > > unsigned int [unsigned] val got restricted snd_pcm_format_t [usertype] > > > > > > > > > sound/soc/intel/haswell.c:61:37 > > > sound/soc/intel/broadwell.c:115:37: > > > sound/soc/intel/bytcr_dpcm_rt5640.c:118:37: > > > sound/soc/intel/cht_bsw_rt5672.c:183:37: > > > sound/soc/intel/cht_bsw_rt5645.c:208:37: > > > > > > Signed-off-by: Fang, Yang A > > > --- > > > sound/soc/intel/broadwell.c | 2 +- > > > sound/soc/intel/bytcr_dpcm_rt5640.c | 2 +- > > > sound/soc/intel/cht_bsw_rt5645.c | 2 +- > > > sound/soc/intel/cht_bsw_rt5672.c | 2 +- > > > sound/soc/intel/haswell.c | 2 +- > > > 5 files changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c > > > index 9cf7d01..0ca4015 100644 > > > --- a/sound/soc/intel/broadwell.c > > > +++ b/sound/soc/intel/broadwell.c > > > @@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct > > snd_soc_pcm_runtime *rtd, > > > /* set SSP0 to 16 bit */ > > > snd_mask_set(¶ms- > > >masks[SNDRV_PCM_HW_PARAM_FORMAT - > > > SNDRV_PCM_HW_PARAM_FIRST_MASK], > > > - SNDRV_PCM_FORMAT_S16_LE); > > > + (__force > > int)SNDRV_PCM_FORMAT_S16_LE); > > > return 0; > > > } > > > > Oh, it's ugly, but unavoidable as long as we use this form. > > > > Maybe it's better to provide a helper, e.g. params_set_format() to do the > > forced cast. > > > > Also, it would be possible to provide the whole hw constraints stuff to make > > it working independently. But I guess it's overkill for DPCM hwparam fixups. > > > > > > Takashi > > Hi Takashi, > > Thanks for the feedback. Are you looking for something like this? > > >masks[SNDRV_PCM_HW_PARAM_FORMAT - > > > SNDRV_PCM_HW_PARAM_FIRST_MASK], > > > - SNDRV_PCM_FORMAT_S16_LE); > > > + params_set_format( SNDRV_PCM_FORMAT_S16_LE)); No, something like below in pcm_params.h: static inline void params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t format) { snd_mask_set(p, (__force int)format); } Takashi