From: Takashi Iwai Subject: Re: [PATCH] Cirrus Logic CS421x support Date: Tue, 26 Jul 2011 12:23:12 +0200 Message-ID: References: <1311370860-29731-1-git-send-email-tim.howe@cirrus.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C5161244DE for ; Tue, 26 Jul 2011 12:23:14 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tim Howe Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 24 Jul 2011 13:56:10 +0200, Takashi Iwai wrote: > > At Fri, 22 Jul 2011 16:41:00 -0500, > Tim Howe wrote: > > > > This update includes the changes necessary for supporting the > > CS421x family of codecs. Previously this file only supported > > the CS420x family of codecs. > > > > This file also contains init verbs to correct several issues in > > the CS421x hardware. > > > > Behavior between the CS421x and CS420x codec families is similar, > > so several functions have been reused with "if" statements to > > determine which codec family (CS421x or CS420x) is present. > > > > Also, this file will be updated sometime in the near future in > > order to add support for a system using CS421x that requires > > mono mix on the speaker output only. > > > > Signed-off-by: Tim Howe > > The patch looks mostly good. Just a few minor points below. Never mind, I fixed these small issues quickly by myself and applied the patch now. Please check sound git tree later whether it's OK. thanks, Takashi