From: Takashi Iwai Subject: Re: [PATCH 0/2] Arcam AV Control Plugin Updates Date: Mon, 23 Feb 2009 10:35:50 +0100 Message-ID: References: <200902211659.48009.linux@dadeos.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 88FF72442A for ; Mon, 23 Feb 2009 10:35:50 +0100 (CET) In-Reply-To: <200902211659.48009.linux@dadeos.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Stokes Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 21 Feb 2009 16:59:47 +0000, Peter Stokes wrote: > > Hi, > > The following patches provide minor updates to the Arcam AV control plug-in. > > * [PATCH 1/2] Remove incorrect usage of the static SHM ID variable > * [PATCH 2/2] Refactor control specifications to facilitate addition of "numid" optimisation > > Takashi, > > I attempted to follow the pattern of your recent commits regarding the "numid" optimisations for external control plug-ins. > Hopefully I've provided the correct behavior. Thanks, applied now. > Something that am not sure about is whether I should be calling > the "snd_ctl_elem_id_set_numid()" function from "ctl_arcam_av.c" "arcam_av_read_event()" either in addition or instead of > the calls to the "snd_ctl_elem_id_set_name()" function? Better to put both. The find_elem() should fill the id fields as much as possible in return. Takashi