From: Takashi Iwai Subject: Re: =?utf-8?q?1=2E0=2E16rc1_release_--_error=3A_?= =?utf-8?b?4oCYc3lzdGVtX3V0c25hbWXigJkgdW5kZWNsYXJlZA==?= Date: Thu, 24 Jan 2008 12:23:23 +0100 Message-ID: References: <20ddc5da0801240240n27f4971fwf8a274ed6156b4e4@mail.gmail.com> <20ddc5da0801240318u6389cbe1l8e6cb4cf0c6f951c@mail.gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx1.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id F3620246B3 for ; Thu, 24 Jan 2008 12:23:23 +0100 (CET) In-Reply-To: <20ddc5da0801240318u6389cbe1l8e6cb4cf0c6f951c@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Brad Milne Cc: Alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 25 Jan 2008 00:18:33 +1300, Brad Milne wrote: > > On Jan 24, 2008 11:58 PM, Takashi Iwai wrote: > > At Thu, 24 Jan 2008 23:40:55 +1300, > > > > Brad Milne wrote: > > > > > > > From tiwai at suse.de Wed Jan 23 08:31:32 2008 > > > > From: tiwai at suse.de (Takashi Iwai) > > > > Date: Wed, 23 Jan 2008 08:31:32 +0100 > > > > Subject: [alsa-devel] > > > > =?iso-8859-7?q?1=2E0=2E16rc1_release_--_error=3A_=A1?= > > > > =?iso-8859-7?q?system=5Futsname=A2_undeclared?= > > > > In-Reply-To: > > > > References: < Pine.LNX.4.61.0801221247570.9698@tm8103.perex-int.cz> > > > > <47964342.1060608@measham.id.au> > > > > Message-ID: > > > > > > > At Wed, 23 Jan 2008 08:03:05 +0100, > > > > I wrote: > > > > > > > > > > At Wed, 23 Jan 2008 06:25:54 +1100, > > > > > Rick Measham wrote: > > > > > > > > > > > > [1 ] > > > > > > [1.1 ] > > > > > > Jaroslav Kysela wrote: > > > > > > > 1.0.16rc1 release is available for download on > > > > > > > > > > > > Running Kubuntu: > > > > > > > > > > > > # uname -a > > > > > > Linux lugtop 2.6.20-16-386 #2 Sun Sep 23 19:47:10 UTC 2007 i686 GNU/Linux > > > > > > > > > > > > > > > > > > During the make: > > > > > > > > > > > > In file included from > > > > > > /usr/src/alsa/alsa-driver-1.0.16rc1/acore/info_oss.c:7: > > > > > > /usr/src/alsa/alsa-driver-1.0.16rc1/acore/../alsa-kernel/core/info_oss.c: > > > > > > In function ?snd_sndstat_proc_read?: > > > > > > /usr/src/alsa/alsa-driver-1.0.16rc1/acore/../alsa-kernel/core/info_oss.c:96: > > > > > > error: ?system_utsname? undeclared (first use in this function) > > > > > > /usr/src/alsa/alsa-driver-1.0.16rc1/acore/../alsa-kernel/core/info_oss.c:96: > > > > > > error: (Each undeclared identifier is reported only once > > > > > > /usr/src/alsa/alsa-driver-1.0.16rc1/acore/../alsa-kernel/core/info_oss.c:96: > > > > > > error: for each function it appears in.) > > > > > > make[3]: *** [/usr/src/alsa/alsa-driver-1.0.16rc1/acore/info_oss.o] Error 1 > > > > > > make[2]: *** [/usr/src/alsa/alsa-driver-1.0.16rc1/acore] Error 2 > > > > > > make[1]: *** [_module_/usr/src/alsa/alsa-driver-1.0.16rc1] Error 2 > > > > > > make[1]: Leaving directory `/usr/src/linux-headers-2.6.20-16-386' > > > > > > make: *** [compile] Error 2 > > > > > > > > > > Isn't it fixed on HG version? > > > > > > > Nevermind, I myself can confirm that it's broken. > > > > The patch below should fix the problem. > > > > > > > > > > Takashi > > > > > > > diff -r a5f603cb254a configure.in > > > > --- a/configure.in Tue Jan 22 17:52:34 2008 +0100 > > > > +++ b/configure.in Wed Jan 23 08:28:56 2008 +0100 > > > > @@ -2571,7 +2571,7 @@ init_utsname="0" > > > > init_utsname="0" > > > > ac_save_CFLAGS="$CFLAGS" > > > > ac_save_CC="$CC" > > > > -CFLAGS="$KERNEL_CHECK_CFLAGS -Werror" > > > > +CFLAGS="$KERNEL_CHECK_CFLAGS -Werror=implicit-function-declaration" > > > > CC=$KCC > > > > AC_TRY_COMPILE([ > > > > #define __KERNEL__ > > > > > > It doesn't seem that it is fixed in HG or by this patch (though I do get: > > > patching file configure.in > > > Hunk #1 succeeded at 1579 with fuzz 2 (offset > > > -992 lines). > > > patch unexpectedly ends in middle of line > > > when patching), I get the exact same error in both. > > > > And did you run hgcompile after that? > > If I run: > sudo ./configure > then: > sudo ./hgcompile You don't have to be root for compiling the driver. The root priv is needed only for installation, i.e. make install. > on the latest hg code, I still get the same error: > from /usr/src/alsa/alsa-driver/acore/info_oss.c:7: > include/linux/utsname.h:77: error: expected '=', ',', ';', 'asm' or > '__attribute__' before '{' token > ... > /usr/src/alsa/alsa-driver/acore/../alsa-kernel/core/info_oss.c: In > function 'snd_sndstat_proc_read': > /usr/src/alsa/alsa-driver/acore/../alsa-kernel/core/info_oss.c:96: > error: 'system_utsname' undeclared (first use in this function) > ... > make[3]: *** [/usr/src/alsa/alsa-driver/acore/info_oss.o] Error 1 > ... Interesting. You're using 2.6.20 kernel, right? First check include/config.h. whether it defines CONFIG_HAVE_INIT_UTSNAME. If it's defined, then the build must go well. If it's undefined (commented out), then check configure.in whether the patch was properly applied and -Werror was changed to -Werror=implicit-function-declaration. And see config.log at the place where init_utsname is checked. You must have a compile error there. Show that part. Takashi