From: Takashi Iwai Subject: Re: Patch for ALC882 Date: Mon, 21 Jan 2008 12:22:14 +0100 Message-ID: References: <1200361715.6964.12.camel@kip-laptop> <1200434828.8884.1.camel@kip-laptop> <1200625227.7715.20.camel@kip-laptop> <1200639924.7715.31.camel@kip-laptop> <1200881047.6980.25.camel@kip-laptop> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (ns2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7358C2442A for ; Mon, 21 Jan 2008 12:22:16 +0100 (CET) In-Reply-To: <1200881047.6980.25.camel@kip-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Kip Warner Cc: pshou@realtek.com.tw, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 20 Jan 2008 18:04:07 -0800, Kip Warner wrote: > > On Fri, 2008-01-18 at 11:00 +0100, Takashi Iwai wrote: > > > The necessary changes are likely only what's in the below. > > Could you try it with the latest HG version, or the latest daily > > snapshot tarball? > > > > > > Takashi > > > > diff -r 1cb5fe1b2443 pci/hda/patch_realtek.c > > --- a/pci/hda/patch_realtek.c Thu Jan 17 17:44:49 2008 +0100 > > +++ b/pci/hda/patch_realtek.c Fri Jan 18 08:28:15 2008 +0100 > > @@ -5645,7 +5645,9 @@ static struct hda_verb alc882_asus_a7j_v > > > > {0x18, AC_VERB_SET_CONNECT_SEL, 0x02}, /* mic/clfe */ > > {0x1a, AC_VERB_SET_CONNECT_SEL, 0x01}, /* line/surround */ > > - {0x1b, AC_VERB_SET_CONNECT_SEL, 0x00}, /* HP */ > > + {0x1b, AC_VERB_SET_CONNECT_SEL, 0x00}, /* line */ > > + {0x1b, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, > > + {0x1b, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE}, > > { } /* end */ > > }; > > > > @@ -5969,7 +5971,8 @@ static struct alc_config_preset alc882_p > > [ALC882_ASUS_A7J] = { > > .mixers = { alc882_asus_a7j_mixer, alc882_chmode_mixer, > > alc882_capture_mixer }, > > - .init_verbs = { alc882_init_verbs, alc882_asus_a7j_verbs}, > > + .init_verbs = { alc882_init_verbs, alc882_asus_a7j_verbs, > > + alc880_gpio1_init_verbs }, > > .num_dacs = ARRAY_SIZE(alc882_dac_nids), > > .dac_nids = alc882_dac_nids, > > .dig_out_nid = ALC882_DIGOUT_NID, > > I just applied your patch against the latest alsa-driver-hg20080120 > bzip'd tarball. I tried it both with and without the patch and both ways > produce proper four speaker sound. Please let me know if I can be of any > further assistance. Hm, so do you mean that the HG version works as is even without the patch above? To be sure, try to reboot in both cases. Takashi