Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAA1C4338F for ; Tue, 17 Aug 2021 05:16:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEA1760230 for ; Tue, 17 Aug 2021 05:16:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CEA1760230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7E7FB823; Tue, 17 Aug 2021 07:15:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7E7FB823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629177364; bh=XcaxMcfKsW6XR817RN50IrGxCxt4Wp+SNZ7u/Pdot1I=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=um3DtVbenKywmgeltiE3aX8/zuaxKkrdZLUvF2BIO0eY9xqG4MCb1sBF7El1Silfs VwbiJ15aa8bvTszpwk4SNpxzClfoQMv9+9JEpW3i+9LZ4tfWfaNGUXo9gfwAZANBtU eyh9WlCec5Q+svAnGJIgSdrEbcRkYHHqqa1MLTnk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 897B1F8026D; Tue, 17 Aug 2021 07:15:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BEAE6F80272; Tue, 17 Aug 2021 07:15:08 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0C69BF80163 for ; Tue, 17 Aug 2021 07:14:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0C69BF80163 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="erH76c7G"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="XbDzqKhL" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C60A021EEF; Tue, 17 Aug 2021 05:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629177296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v2pgY4cHcaMOR2LwtJOlFKupaEZUICEIOZsKhHAcJgk=; b=erH76c7GywLRkTat31vw7aV/puuXax89NKbuzXQuaEfFWu3ULDBjqA/g9qG8ZKMUPGuBqQ D7y5xxAcgngthkyIFxY620u8xFrN4DAf7F3o8k1xC9rg+UR3Hm64F32spEsUk3Z3Yc9rin Aw21GQ65JiHvKZsZF5o4N7T+HUtAwI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629177296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v2pgY4cHcaMOR2LwtJOlFKupaEZUICEIOZsKhHAcJgk=; b=XbDzqKhLLabKjHtKYQE3n5BBThA2ch+4S75iOeRK+3BjGP9DfqH/anQbrx+KJ9BR74FjE+ m4g8BUrD/SECITDg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B9B8FA3B8F; Tue, 17 Aug 2021 05:14:56 +0000 (UTC) Date: Tue, 17 Aug 2021 07:14:56 +0200 Message-ID: From: Takashi Iwai To: Imre Deak Subject: Re: [PATCH] ALSA: hda: Fix hang during shutdown due to link reset In-Reply-To: <20210816174259.2759103-1-imre.deak@intel.com> References: <20210816174259.2759103-1-imre.deak@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, youling257@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 16 Aug 2021 19:42:59 +0200, Imre Deak wrote: > > During system shutdown codecs may be still active, and resetting the > controller->codec HW link in this state - based on the bug reporter's > tests - leads to the shutdown sequence to get stuck. This happens at > least on the reporter's KBL system with an ALC662 codec. > > For now fix the issue by skipping the link reset step. > > Fixes: 472e18f63c42 ("ALSA: hda: Release controller display power during shutdown/reboot") > References: https://bugzilla.kernel.org/show_bug.cgi?id=214045 > References: https://gitlab.freedesktop.org/drm/intel/-/issues/3618#note_1024665 > Reported-and-tested-by: youling257@gmail.com > Cc: Takashi Iwai > Cc: youling257@gmail.com > Signed-off-by: Imre Deak Thanks, applied now. Takashi