From: Takashi Iwai Subject: Re: [PATCH] sound: pci: cthw20k2: Replace mdelay() with msleep() and usleep_range() Date: Fri, 27 Jul 2018 11:49:58 +0200 Message-ID: References: <20180727090143.18686-1-baijiaju1990@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3DB002677CB for ; Fri, 27 Jul 2018 11:49:59 +0200 (CEST) In-Reply-To: <20180727090143.18686-1-baijiaju1990@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jia-Ju Bai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, bhumirks@gmail.com List-Id: alsa-devel@alsa-project.org On Fri, 27 Jul 2018 11:01:43 +0200, Jia-Ju Bai wrote: > > hw_pll_init(), hw_dac_stop(), hw_dac_start() and hw_adc_init() > are never called in atomic context. > They call mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied, thanks. Takashi