From: Takashi Iwai Subject: Re: [alsa-lib][PATCH] topology: Fix to skip writing of header for compound elements Date: Tue, 02 Jan 2018 16:34:35 +0100 Message-ID: References: <20180102052001.6952-1-guneshwor.o.singh@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 843E22673D6 for ; Tue, 2 Jan 2018 16:34:37 +0100 (CET) In-Reply-To: <20180102052001.6952-1-guneshwor.o.singh@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Guneshwor Singh Cc: Patches Audio , ALSA , "Subhransu S . Prusty" , GuruprasadX Pawse List-Id: alsa-devel@alsa-project.org On Tue, 02 Jan 2018 06:20:01 +0100, Guneshwor Singh wrote: > > From: GuruprasadX Pawse > > While calculating the size of data to be written into the topology > binary file, the size of the compound elements is added as well. This > results in wrong file offset calculation and topology build failure. > > The compound elements shouldn't be written to the topology as these are > already embedded as part of other elements. So, skip adding the size of > compound elements to the file offset size calculation. > > Signed-off-by: GuruprasadX Pawse > Signed-off-by: Subhransu S. Prusty > Signed-off-by: Guneshwor Singh Applied, thanks. Takashi