From: Takashi Iwai Subject: Re: [PATCH] alsactl: Move systemd unit start-up from basic.target to sound.target Date: Fri, 06 Oct 2017 14:36:17 +0200 Message-ID: References: <20170926183612.9646-1-aklhfex@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BC43B266D08 for ; Fri, 6 Oct 2017 14:36:18 +0200 (CEST) In-Reply-To: <20170926183612.9646-1-aklhfex@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Chris Mayo Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 26 Sep 2017 20:36:12 +0200, Chris Mayo wrote: > > Ensures soundcard is ready before restoring state. > > sound.target added to systemd in v18: > https://cgit.freedesktop.org/systemd/systemd/commit/?id=88dfa2938af > > Simplify dependencies: > - After=alsa-state.service is not needed because both units test for > @daemonswitch@ with opposite outcomes. > > - After=sysinit.target is automatically added by systemd. > > First proposed by Tom Yan. > > Signed-off-by: Chris Mayo > --- > > I need this because my Sound Blaster Titanium is not ready by the time > basic.target is reached. > > It was proposed last year by Tom Yan but looks like it didn't get in > because requested config checks and documentation didn't materialise. > https://www.spinics.net/lists/alsa-devel/msg45537.html > > I've added those (PKG_CHECK_MODULES outputs a message at configure time). > > I've left ConditionPathExistsGlob=/dev/snd/control* in > alsa-restore.service because although it would normally be started by the > udev rule and sound.target there's no guarantee that is how it was started. Thanks, this looks like a sensitive change. Applied now. Takashi