From: Takashi Iwai Subject: Re: [PATCH v2 6/6] pcm:plug: save converter config Date: Mon, 27 Feb 2017 09:14:31 +0100 Message-ID: References: <1488180992-9180-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488180992-9180-1-git-send-email-sutar.mounesh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: sutar.mounesh@gmail.com Cc: alsa-devel@alsa-project.org, patch@alsa-project.org, Andreas Pape , mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Mon, 27 Feb 2017 08:36:32 +0100, sutar.mounesh@gmail.com wrote: > > From: Andreas Pape > > Passed config is freed after call to open, thus it is invalid when > trying to extract the converter name. So config entry is saved > for later usage. > > Signed-off-by: Andreas Pape > Signed-off-by: Mounesh Sutar > > diff --git a/src/pcm/pcm_plug.c b/src/pcm/pcm_plug.c > index 266707b..ad0e99e 100644 > --- a/src/pcm/pcm_plug.c > +++ b/src/pcm/pcm_plug.c > @@ -64,6 +64,8 @@ static int snd_pcm_plug_close(snd_pcm_t *pcm) > snd_pcm_plug_t *plug = pcm->private_data; > int err, result = 0; > free(plug->ttable); > + if (plug->rate_converter) > + snd_config_delete((snd_config_t*)plug->rate_converter); Set NULL after calling snd_config_delete(), so that it won't double-free. > assert(plug->gen.slave == plug->req_slave); > if (plug->gen.close_slave) { > snd_pcm_unlink_hw_ptr(pcm, plug->req_slave); > @@ -1108,7 +1110,13 @@ int snd_pcm_plug_open(snd_pcm_t **pcmp, > plug->sformat = sformat; > plug->schannels = schannels; > plug->srate = srate; > - plug->rate_converter = rate_converter; > + if (rate_converter) { > + if ((err = snd_config_copy((snd_config_t**)&plug->rate_converter, > + (snd_config_t *)rate_converter)) < 0) > + free(plug); > + return err; Missing braces. It'll go out unconditionally. Did you really try this patch and confirm to work...? thanks, Takashi