From: Takashi Iwai Subject: Re: [PATCH 04/10] ASoC: Intel: Skylake: Disable SRAM Retention before D3 Date: Fri, 03 Jun 2016 15:04:14 +0200 Message-ID: References: <1464958783-19344-1-git-send-email-jeeja.kp@intel.com> <1464958783-19344-5-git-send-email-jeeja.kp@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D54F7261497 for ; Fri, 3 Jun 2016 15:04:16 +0200 (CEST) In-Reply-To: <1464958783-19344-5-git-send-email-jeeja.kp@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: jeeja.kp@intel.com Cc: alsa-devel@alsa-project.org, Dharageswari R , patches.audio@intel.com, Vinod Koul , broonie@kernel.org, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org On Fri, 03 Jun 2016 14:59:37 +0200, jeeja.kp@intel.com wrote: > > From: Dharageswari R > > SW needs to set the PGCTL.LSRMD = 1 to disable LPSRAM retention > feature,otherwise it may lead to SRAM ECC Errors. Is this needed only for ASoC driver, or for SKL in general? thanks, Takashi > > Signed-off-by: Dharageswari R > Signed-off-by: Jeeja KP > Signed-off-by: Vinod Koul > --- > sound/soc/intel/skylake/skl.c | 3 +++ > sound/soc/intel/skylake/skl.h | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c > index 06d8c26..5a08826 100644 > --- a/sound/soc/intel/skylake/skl.c > +++ b/sound/soc/intel/skylake/skl.c > @@ -184,6 +184,7 @@ static int _skl_suspend(struct hdac_ext_bus *ebus) > { > struct skl *skl = ebus_to_skl(ebus); > struct hdac_bus *bus = ebus_to_hbus(ebus); > + struct pci_dev *pci = to_pci_dev(bus->dev); > int ret; > > snd_hdac_ext_bus_link_power_down_all(ebus); > @@ -193,6 +194,8 @@ static int _skl_suspend(struct hdac_ext_bus *ebus) > return ret; > > snd_hdac_bus_stop_chip(bus); > + update_pci_dword(pci, AZX_PCIREG_PGCTL, > + AZX_PGCTL_LSRMD_MASK, AZX_PGCTL_LSRMD_MASK); > skl_enable_miscbdcge(bus->dev, false); > snd_hdac_bus_enter_link_reset(bus); > skl_enable_miscbdcge(bus->dev, true); > diff --git a/sound/soc/intel/skylake/skl.h b/sound/soc/intel/skylake/skl.h > index 4b4b387..bd8db1d 100644 > --- a/sound/soc/intel/skylake/skl.h > +++ b/sound/soc/intel/skylake/skl.h > @@ -48,6 +48,8 @@ > #define AZX_REG_VS_SDXEFIFOS_XBASE 0x1094 > #define AZX_REG_VS_SDXEFIFOS_XINTERVAL 0x20 > > +#define AZX_PCIREG_PGCTL 0x44 > +#define AZX_PGCTL_LSRMD_MASK (1 << 4) > #define AZX_PCIREG_CGCTL 0x48 > #define AZX_CGCTL_MISCBDCGE_MASK (1 << 6) > > -- > 2.5.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >