From: Takashi Iwai Subject: Re: [PATCH v3 1/3] conf: topology: Add Skylake i2s conf Date: Thu, 21 Apr 2016 09:22:09 +0200 Message-ID: References: <1461220058-1378-1-git-send-email-vinod.koul@intel.com> <1461220058-1378-2-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A49922604DF for ; Thu, 21 Apr 2016 09:22:10 +0200 (CEST) In-Reply-To: <1461220058-1378-2-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, liam.r.girdwood@linux.intel.com, broonie@kernel.org, Shreyas NC , "Subhransu S. Prusty" List-Id: alsa-devel@alsa-project.org On Thu, 21 Apr 2016 08:27:36 +0200, Vinod Koul wrote: > > From: Shreyas NC > > The Skylake topology configuration for simple topology graph is > provided. This exposes the PCM capabilities of the DSP. > > Signed-off-by: Shreyas NC > Signed-off-by: Subhransu S. Prusty > Signed-off-by: Vinod Koul > --- > configure.ac | 1 + > src/conf/topology/Makefile.am | 2 +- > src/conf/topology/sklrt286/Makefile.am | 11 + > src/conf/topology/sklrt286/skl_i2s.conf | 342 ++++++++++++++++++++++++++++++++ > 4 files changed, 355 insertions(+), 1 deletion(-) > create mode 100644 src/conf/topology/sklrt286/Makefile.am > create mode 100644 src/conf/topology/sklrt286/skl_i2s.conf > > diff --git a/configure.ac b/configure.ac > index c265ec9e159b..1bf75e6d9c2b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -661,6 +661,7 @@ AC_OUTPUT(Makefile doc/Makefile doc/pictures/Makefile doc/doxygen.cfg \ > src/conf/topology/Makefile \ > src/conf/topology/broadwell/Makefile \ > modules/Makefile modules/mixer/Makefile modules/mixer/simple/Makefile \ > + src/conf/topology/sklrt286/Makefile \ > alsalisp/Makefile aserver/Makefile \ > test/Makefile test/lsb/Makefile \ > utils/Makefile utils/alsa-lib.spec utils/alsa.pc) > diff --git a/src/conf/topology/Makefile.am b/src/conf/topology/Makefile.am > index f56a96c651e5..cbdb7cf07c97 100644 > --- a/src/conf/topology/Makefile.am > +++ b/src/conf/topology/Makefile.am > @@ -1 +1 @@ > -SUBDIRS=broadwell > +SUBDIRS=broadwell sklrt286 > diff --git a/src/conf/topology/sklrt286/Makefile.am b/src/conf/topology/sklrt286/Makefile.am > new file mode 100644 > index 000000000000..f10d12fa0f73 > --- /dev/null > +++ b/src/conf/topology/sklrt286/Makefile.am > @@ -0,0 +1,11 @@ > +alsaconfigdir = @ALSA_CONFIG_DIR@ > +SUBDIRS = data > +sklrt286dir = $(alsaconfigdir)/topology/sklrt286 > +sklrt286_DATA = skl_i2s.conf > +EXTRA_DIST = sklrt286_DATA Isn't it $(sklrt286_DATA)? > +install-data-hook: > + cp -p media0_in-cpr-0.bin media0_in-mi.bin media0_out-mo.bin media0_out-cpr-6.bin codec0_out-mo.bin codec0_out-cpr-4.bin codec1_out-mo.bin codec1_out-cpr-5.bin codec0_in-cpr-1.bin codec0_in-mi.bin dmic01_hifi_in-cpr-3.bin dmic01_hifi_in-mi.bin hdmi1_pt_out-cpr-7.bin hdmi1_pt_out-cpr-8.bin hdmi2_pt_out-cpr-9.bin hdmi2_pt_out-cpr-10.bin hdmi3_pt_out-cpr-11.bin hdmi3_pt_out-cpr-12.bin $(sklrt286dir) I guess these bin files aren't present or generated in this patch? This would break bisection. thanks, Takashi