From: Takashi Iwai Subject: Re: [PATCH] ALSA: core: Add 384kHz Support Date: Wed, 27 Jan 2016 15:36:08 +0100 Message-ID: References: <1453902825-27002-1-git-send-email-brian.austin@cirrus.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BF07026044B for ; Wed, 27 Jan 2016 15:36:08 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Brian Austin Cc: alsa-devel@alsa-project.org, paul.handrigan@cirrus.com, charles.keepax@cirrus.com List-Id: alsa-devel@alsa-project.org On Wed, 27 Jan 2016 15:11:10 +0100, Brian Austin wrote: > > On Wed, 27 Jan 2016, Takashi Iwai wrote: > > > On Wed, 27 Jan 2016 14:53:45 +0100, > > wrote: > > > > > > From: Brian Austin > > > > > > Adding support for 384kHz audio sample rates > > > > The most important information is missing: why this is needed. > So I can specify that I want 384kHz. > > > > (Note that the support of 384kHz itself can be done without this > > addition :) > > > So we stay at SNDRV_PCM_RATE_192000 always for sample rate defines? > And everything else is just covered with SNDRV_PCM_RATE_KNOT? Depends. If a new sample rate is (or will be) demanded by many drivers, it's worth to add it, of course, as it would simplify the code. That's why I mentioned "why" is most important information; you need to convince others about the necessity of this change, after all. Then you see that "because I-wanna-it" doesn't sound convincing enough, right? Takashi