From: Takashi Iwai Subject: Re: [PATCH] snd-usb-us122l: added support for US-144 Date: Tue, 22 Sep 2009 15:14:05 +0200 Message-ID: References: <4AB82D17.8090100@physik.uni-hamburg.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 9AAEE24334 for ; Tue, 22 Sep 2009 15:14:05 +0200 (CEST) In-Reply-To: <4AB82D17.8090100@physik.uni-hamburg.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tobias Hansen Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 22 Sep 2009 03:49:11 +0200, Tobias Hansen wrote: > > @@ -443,6 +476,13 @@ > int err; > struct us122l *us122l = US122L(card); > > + if (us122l->chip.dev->descriptor.idProduct == USB_ID_US144) { > + err = usb_set_interface(us122l->chip.dev, 0, 1); > + if (err) { > + snd_printk(KERN_ERR "usb_set_interface error \n"); > + return false; > + } > + } > err = usb_set_interface(us122l->chip.dev, 1, 1); > if (err) { > snd_printk(KERN_ERR "usb_set_interface error \n"); Strictly speaking, the first interface should be reset in the error path... > @@ -530,7 +573,7 @@ > if (err < 0) > return err; > > - snd_card_set_dev(card, &intf->dev); > + snd_card_set_dev(card, &device->dev); > if (!us122l_create_card(card)) { > snd_card_free(card); > return -EINVAL; Any reason to change this again? This actually reverts the fix in the upstream: 3f5d3465be8f6e04f43d9b6d543fe28d4be07d78 ALSA: usx2y - reparent sound device Also, please give your sign-off. See $LINUX/Documentation/SubmittingPatches for details. Could you repost with it? thanks, Takashi