From: Takashi Iwai Subject: Re: cs4248 / thinkpad 755 / 755c , patch suggestions Date: Thu, 03 Jul 2003 14:29:01 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <20030702185006.GU24005@dbz.icequake.net> <20030702202955.GW24005@dbz.icequake.net> Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20030702202955.GW24005@dbz.icequake.net> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Ryan Underwood Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 2 Jul 2003 15:29:55 -0500, Ryan Underwood wrote: > > 1) What is ALSA's policy on module options? For example, would it be > okay to add an option like "thinkpad" to the ad1848 module, so that > inserting it with "thinkpad=1" would cause the necessary ports to be > prodded? this looks like a feasible solution. > 2) Since the chip's power mode can be controlled through a write to that > port (bit 2 on, cs4248 power on; bit 2 off, cs4248 power off), would it > be a good idea to add the _suspend, _resume, and _set_power_state > functions within a #ifdef CONFIG_PM block, like in other drivers? yep. we haven't done that just becase of lack of hardware. if you can write and test it, it would be greatly appreciated. Takashi ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01