Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C48D3C4361B for ; Fri, 11 Dec 2020 13:28:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D468229C4 for ; Fri, 11 Dec 2020 13:28:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D468229C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 825141758; Fri, 11 Dec 2020 14:27:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 825141758 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607693306; bh=w/bzGzcG1EUJzllaOhECNYCAqB7jd6zs2WcSzyQ+v6M=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gU3NW5ikNRg7LjqsPeTb2A+huhmi1lzPpMGSv/ZE+OOS1Njgu/A3SKvPASCrCKpCC pMuhxcaF5s5UuFASxjw2k+vw1E2L1XaHV/bx5SJeCwLMXXBO8MvYXaHfVlTyehlrBp zFHd4r1SUj/u091Zd3j82/kl2NelpDR7N4RJKx5I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0F53DF801D8; Fri, 11 Dec 2020 14:27:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE12FF8020D; Fri, 11 Dec 2020 14:27:34 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D0D6FF80105 for ; Fri, 11 Dec 2020 14:27:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D0D6FF80105 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C0F6AC10; Fri, 11 Dec 2020 13:27:25 +0000 (UTC) Date: Fri, 11 Dec 2020 14:27:25 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda/hdmi: packet buffer index must be set before reading value In-Reply-To: <20201211131613.3271407-1-kai.vehmanen@linux.intel.com> References: <20201211131613.3271407-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 11 Dec 2020 14:16:13 +0100, Kai Vehmanen wrote: > > The check for infoframe transmit status in hdmi_infoframe_uptodate() > makes the assumption that packet buffer index is set to zero. > > Align code with specification and explicitly set the index before > AC_VERB_GET_HDMI_DIP_XMIT. The packet index setting affects both > DIP-Data and DIP-XmitCtrl verbs. > > There are no known cases where the old implementation has caused driver > to work incorrectly. This change is purely based on code review against > the specification (HDA spec rev1.0a). > > Signed-off-by: Kai Vehmanen Currently there is no other place to change DIP index, i.e. it's always zero, and the bug wouldn't hit, but it's better to be addressed beforehand, indeed. Applied now. Thanks. Takashi