Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497F0C2BA19 for ; Tue, 14 Apr 2020 13:07:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C226B208FE for ; Tue, 14 Apr 2020 13:07:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="EH9+BVu0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C226B208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 184111691; Tue, 14 Apr 2020 15:06:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 184111691 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586869626; bh=Pr+ccCPrmb8iyltvuUBu8+Y7Z1aaa/RBl7ZwVjV2sj8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EH9+BVu0YrUjeuiIwhpQ5WlIwJ48tHQMJhG3sfKEAV21xxCu1JgP0d3sQAxYR1w3v kjb6QsxO3BsPnYf1aEs4vz6fz9KoSmGGa12wog7u21u+F+j/BHv67EC0wGyrNQN2ro 01shCknWAQEwUDMFhwLu57CNsOPA4EhBbI9qF2Dg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 97679F80126; Tue, 14 Apr 2020 15:06:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FF91F8013D; Tue, 14 Apr 2020 15:06:14 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9784CF80115 for ; Tue, 14 Apr 2020 15:06:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9784CF80115 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 57B21ABBD; Tue, 14 Apr 2020 13:06:00 +0000 (UTC) Date: Tue, 14 Apr 2020 15:06:00 +0200 Message-ID: From: Takashi Iwai To: Roy Spliet Subject: Re: [PATCH] ALSA: hda: enable the runtime_pm for non-vgaswitcheroo hda controllers In-Reply-To: References: <20200414101405.6992-1-hui.wang@canonical.com> <121237cf-8ef9-2a21-8ee3-6c6954e846e2@canonical.com> <9e8a7b1b-decc-d149-6b86-01946df82d54@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Hui Wang , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 14 Apr 2020 14:59:01 +0200, Roy Spliet wrote: > > Op 14-04-2020 om 13:56 schreef Hui Wang: > > > > On 2020/4/14 下午8:42, Roy Spliet wrote: > >> Dear Hui, Takashi, > >> > >> Op 14-04-2020 om 13:35 schreef Hui Wang: > >>> > >>> On 2020/4/14 下午6:27, Takashi Iwai wrote: > >>>> On Tue, 14 Apr 2020 12:14:05 +0200, > >>>> Hui Wang wrote: > >>>>> Before the pci_driver->probe() is called, the pci subsystem calls > >>>>> runtime_forbib() and runtime_get_sync() on this pci dev, so only call > >>>>> runtime_put_autosuspend() is not enough to enable the runtime_pm on > >>>>> this device. > >>>>> > >>>>> For controllers with vgaswitcheroo feature, the pci/quirks.c will call > >>>>> runtime_allow() for this dev, then the controllers could enter > >>>>> rt_idle/suspend/resume, but for non-vgaswitcheroo controllers like > >>>>> Intel hda controllers, the runtime_pm is not enabled even it calls > >>>>> put_autosuspend(). Need to call runtime_allow() for those controllers > >>>>> in the hda driver. > >> > >> From what I can tell there are no ill effects of calling > >> runtime_allow() twice. Technically, the check against > >> use_vga_switcheroo() is thus redundant. > >> Is there a good reason why runtime_allow() is called in the pci > >> quirks rather than in hda_intel? Is it a suggestion to perform this > >> call in hda_intel regardless of whether it's a switcheroo-device or > >> not, and removing calls to runtime_allow() from the PCI quirks? > > > > I guess after the hda driver calls the _allow() unconditionally, we > > could remove the _allow() in the pci/quirks.c. But it is no harm > > keeping it since _allow() could be called many times. > > After a bit of research, I agree! It's better left in place in the PCI > quirks, such that in the case that hda_intel doesn't load or bind for > whatever reason (not compiled in e.g. an embedded kernel, new/unknown > PCI vendor/device identifier), the GPUs HDA device can still run-time > suspend. Right, some background information is found in the original commit that introduced the quirk (07f4f97d7b4b). Hui, care to resend the patch with that change, also a bit refreshing the patch description? thanks, Takashi > Thank you! Best, > > Roy > > > > > Thanks, > > > > Hui. > > > >> Thanks. Best, > >> > >> Roy > >>>>> > >>>>> Signed-off-by: Hui Wang > >>>> Was this behavior changed from the earlier kernels?  I thought this > >>>> was left untouched because it's supposed to be set via udev rules or > >>>> such. > >>> > >>> Oh, I don't know that,  according to my test with ubuntu rootfs, > >>> the runtime pm is not enabled on Intel's hda controllers. But with > >>> the sof driver, the controller driver calls runtime_allow() > >>> (soc/sof/sof-pci-dev.c), so I sent this patch. > >>> > >>> Regards, > >>> > >>> Hui. > >>> > >>>> OTOH, enabling the runtime PM is almost mandatory for modern systems, > >>>> and I'm fine to apply this kind of forcible enablement. > >>>> > >>>> > >>>> thanks, > >>>> > >>>> Takashi > >>>> > >>>> > >>>>> --- > >>>>>   sound/pci/hda/hda_intel.c | 2 ++ > >>>>>   1 file changed, 2 insertions(+) > >>>>> > >>>>> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > >>>>> index 8519051a426e..779705bef88b 100644 > >>>>> --- a/sound/pci/hda/hda_intel.c > >>>>> +++ b/sound/pci/hda/hda_intel.c > >>>>> @@ -2356,6 +2356,8 @@ static int azx_probe_continue(struct azx *chip) > >>>>>       if (azx_has_pm_runtime(chip)) { > >>>>>           pm_runtime_use_autosuspend(&pci->dev); > >>>>> +        if (!use_vga_switcheroo(chip)) > >>>>> +            pm_runtime_allow(&pci->dev); > >>>>>           pm_runtime_put_autosuspend(&pci->dev); > >>>>>       } > >>>>> -- > >>>>> 2.17.1 > >>>>> >