From: Takashi Iwai Subject: Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate Date: Mon, 18 Jun 2018 17:40:48 +0200 Message-ID: References: <20180617134652.1638-1-stefan@agner.ch> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 142812673C7 for ; Mon, 18 Jun 2018 17:40:48 +0200 (CEST) In-Reply-To: <20180617134652.1638-1-stefan@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Stefan Agner Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, 17 Jun 2018 15:46:49 +0200, Stefan Agner wrote: > > Currently a variable of type enum CT_AMIXER_CTL is used for enum > CT_SUM_CTL values. This leads to warnings when using clang: > sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type > 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL' > [-Wenum-conversion] > for (i = AMIXER_MASTER_F, j = SUM_IN_F; > ~ ^~~~~~~~ > sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type > 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL' > [-Wenum-conversion] > for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) { > ~ ^~~~~~~~ > > Introduce enum CT_SUM_CTL k and it instead. > > Signed-off-by: Stefan Agner Applied, thanks. Takashi