From: Takashi Iwai Subject: Re: [PATCH v5 6/6] pcm:plug: save converter config Date: Tue, 21 Mar 2017 16:41:48 +0100 Message-ID: References: <1490101098-24998-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BAAC3266718 for ; Tue, 21 Mar 2017 16:41:50 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: sutar.mounesh@gmail.com, alsa-devel@alsa-project.org, Andreas Pape , mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Tue, 21 Mar 2017 16:33:11 +0100, Takashi Sakamoto wrote: > > On Mar 21 2017 21:58, sutar.mounesh@gmail.com wrote: > > From: Andreas Pape > > > > Passed config is freed after call to open, thus it is invalid when > > trying to extract the converter name. So config entry is saved > > for later usage. > > > > Signed-off-by: Andreas Pape > > Signed-off-by: Mounesh Sutar > > Reviewd-by: Takashi Sakamoto > > Iwa-san, would you please modify indentation of second argument > of 'snd_config_copy()' when applying this patch? One space is > required if we strictly follow coding convention, I think. OK, applied with a slight modification. thanks, Takashi