From: Takashi Iwai Subject: Re: [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Date: Thu, 21 Apr 2016 09:19:56 +0200 Message-ID: References: <1461220058-1378-1-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 09E812604DF for ; Thu, 21 Apr 2016 09:19:57 +0200 (CEST) In-Reply-To: <1461220058-1378-1-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 21 Apr 2016 08:27:35 +0200, Vinod Koul wrote: > > This series adds SKL-i2c conf for simple PCM topology graph > > Changes in v3: > > - remove bin blobs, now they are generated in install step This isn't good in general. Usually all installed files are generated in the normal make step, and make-install only copies them. There are a few reasons: - Invoking a random program as root is a security risk. - This may create a file by root in the working directory, and either it's not always possible (e.g. on NFS) or it may be left undeletable after make install. thanks, Takashi > - hook the tool compilation to alsa-lib and run it on install > - add u8 in alsa type_compat.h > > Shreyas NC (3): > conf: topology: Add Skylake i2s conf > Add u8 in type_compat.h > conf: topology: Generate Private data binary blobs > > configure.ac | 2 + > include/sound/type_compat.h | 2 + > src/conf/topology/Makefile.am | 2 +- > src/conf/topology/sklrt286/Makefile.am | 11 + > src/conf/topology/sklrt286/data/Makefile.am | 6 + > src/conf/topology/sklrt286/data/pvt.c | 1815 ++++++++++++++++++++ > src/conf/topology/sklrt286/data/pvt_data.c | 90 + > src/conf/topology/sklrt286/data/pvt_local.h | 9 + > .../topology/sklrt286/data/skl-tplg-interface.h | 232 +++ > src/conf/topology/sklrt286/skl_i2s.conf | 342 ++++ > 10 files changed, 2510 insertions(+), 1 deletion(-) > create mode 100644 src/conf/topology/sklrt286/Makefile.am > create mode 100644 src/conf/topology/sklrt286/data/Makefile.am > create mode 100644 src/conf/topology/sklrt286/data/pvt.c > create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c > create mode 100644 src/conf/topology/sklrt286/data/pvt_local.h > create mode 100644 src/conf/topology/sklrt286/data/skl-tplg-interface.h > create mode 100644 src/conf/topology/sklrt286/skl_i2s.conf > > -- > 1.9.1 >