From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Fix a wrong busy check in alt PCM open Date: Sun, 02 Aug 2015 09:12:24 +0200 Message-ID: References: <1436340574-28256-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 53980260713 for ; Sun, 2 Aug 2015 09:12:25 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: alsa-devel@alsa-project.org, kailang@realtek.com List-Id: alsa-devel@alsa-project.org On Sun, 02 Aug 2015 08:03:25 +0200, Raymond Yau wrote: > > > > > Currently, the alt PCM open callback returns -EBUSY when an > > independent HP is turned off, supposing that it conflicts with the > > main PCM. However, obviously, this check is wrong when the > > independent HP itself isn't enabled but the alt PCM was explicitly > > created via alc_dac_nid by a codec driver. > > The alt_pcm is created only when indep_hp == 1 > > When indep_hp_enable = 0, HP is reconnected to analog device stream , alt > analog device return ebusy > > This look like bug in indep_hp_possible() which should return false when HP > and Line Out/Speaker share same DAC The problem happens in a very special case where the codec driver enables the alt PCM manually in a fixup. It doesn't exist in the current code, so this is no real problem, but just a hypothetical issue. Takashi