From: Takashi Iwai Subject: Re: [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver Date: Mon, 01 Jun 2015 07:32:14 +0200 Message-ID: References: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> <1431341645-2457-6-git-send-email-vinod.koul@intel.com> <20150529174115.GR21577@sirena.org.uk> <20150601051358.GI3140@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C31CC2619D7 for ; Mon, 1 Jun 2015 07:32:17 +0200 (CEST) In-Reply-To: <20150601051358.GI3140@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, liam.r.girdwood@linux.intel.com, Mark Brown , Jeeja KP , "Subhransu S. Prusty" List-Id: alsa-devel@alsa-project.org At Mon, 1 Jun 2015 10:43:58 +0530, Vinod Koul wrote: > > > > +static int azx_acquire_irq(struct soc_hdac_bus *sbus, int do_disconnect) > > > +{ > > > + struct hda_skl *hda = to_hda_skl(sbus); > > > + struct hdac_bus *bus = hdac_bus(sbus); > > > + int ret = 0; > > > + > > > + ret = request_threaded_irq(hda->pci->irq, azx_interrupt, > > > + azx_threaded_handler, > > > + hda->msi ? 0 : IRQF_SHARED, > > > + KBUILD_MODNAME, sbus); > > > > Why not just always request the interrupt as shared - we don't seem to > > care in the interrupt handling code? > I think we can move this to shared only MSI is the exclusive irq, thus shouldn't be shared. Takashi