From: Takashi Iwai Subject: Re: [PATCH RFC] ALSA: usb-audio: add front jack channel selector for EMU0204 Date: Fri, 12 Jul 2013 15:34:31 +0200 Message-ID: References: <1373572671-3851-1-git-send-email-anarsoul@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 69EE6265167 for ; Fri, 12 Jul 2013 15:33:09 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vasily Khoruzhick Cc: Yury Bushmelev , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 12 Jul 2013 16:24:44 +0300, Vasily Khoruzhick wrote: > > On Fri, Jul 12, 2013 at 3:59 PM, Takashi Iwai wrote: > > > > Control request looks like generic UAC_SET_CUR request, but with a bit > > weird values, > > > valid values are { 0x01, 0x01} and { 0x01, 0x02 }, and there's no such > > control type ATM. > > > I'm not well familiar with UAC so any suggestins how to get rid of > > custom control req are welcome! > > > > snd_usb_ctl_msg() call should be rewritten not to pass magic numbers > > but use constants, e.g. > > 0x01 = UAC_SET_CUR, > > 0x21 = USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_OUT > > ... > > > > OK, but how to interpret wIndex and wValue values? Depends :) Takashi > > And, in this case, it'd be more natural to implement as an enum > > control instead of a switch. > > > > OK > > > > > > > > thanks, > > > > Takashi > > > > > Thanks for review! > > Regards > Vasily