From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda_intel: add position_fix quirk for Asus K53E Date: Mon, 10 Sep 2012 10:34:09 +0200 Message-ID: References: <1347226871-2552-1-git-send-email-iacobcatalin@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 2E1F1264FD1 for ; Mon, 10 Sep 2012 10:34:10 +0200 (CEST) In-Reply-To: <1347226871-2552-1-git-send-email-iacobcatalin@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Catalin Iacob Cc: alsa-devel@alsa-project.org, Seth Heasley List-Id: alsa-devel@alsa-project.org At Sun, 9 Sep 2012 21:41:11 +0000, Catalin Iacob wrote: > > Commit c20c5a841cbe47f5b7812b57bd25397497e5fbc0 changed some chipsets to > default to POS_FIX_COMBO so they now use POS_FIX_LPIB instead of > POS_FIX_POSBUF. Since then I've been getting artifacts on playback, including > repeated sounds on my Asus laptop. > > My hardware is Cougar Point which the commit log of > c20c5a841cbe47f5b7812b57bd25397497e5fbc0 mentions as tested so POS_FIX_COMBO > probably works in general but apparently it doesn't on Asus K53E therefore the > need for the quirk. > > Signed-off-by: Catalin Iacob Interesting. Nowadays it's true for almost all devices I know that LPIB works better than POSBUF, so I'm surprised by moving back to POSBUF. What sound backend are you using? PulseAudio? Also, setting bdl_pos_adj=0 option makes any difference? thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 60882c6..228cdf9 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2701,6 +2701,7 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1043, 0x81b3, "ASUS", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), > + SND_PCI_QUIRK(0x1043, 0x1b43, "ASUS K53E", POS_FIX_POSBUF), > SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), > SND_PCI_QUIRK(0x10de, 0xcb89, "Macbook Pro 7,1", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), > -- > 1.7.11.5 >