From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - add dock support for Thinkpad T430s Date: Mon, 06 Aug 2012 13:08:56 +0200 Message-ID: References: <1344250804-14022-1-git-send-email-phiamo@googlemail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B2EDA264F9B for ; Mon, 6 Aug 2012 12:39:13 +0200 (CEST) In-Reply-To: <1344250804-14022-1-git-send-email-phiamo@googlemail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: phiamo Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 6 Aug 2012 13:00:04 +0200, phiamo wrote: > > Based on commit 108cc108a3bb42fe4705df1317ff98e1e29428a6: > > Also add a model/fixup string "lenovo-dock", so that other Thinkpad > users will be able to test this fixup easily, to see if it enables > dock I/O for them as well. Well, this text is just a copy from the commit above. It's rather confusing to put such a text. Just concentrate on what your patch fixes. Thus, the text below is enough. > Tested on Lenovo T430s with ThinkPad Mini Dock Plus Series 3 > > Cc: stable@kernel.org > Signed-off-by: phiamo The sign-off must be done by a real name. Could you resend the patch after fixing these? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b9a5c45..bb93f92 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6207,6 +6207,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x21ca, "Thinkpad L412", ALC269_FIXUP_SKU_IGNORE), > SND_PCI_QUIRK(0x17aa, 0x21e9, "Thinkpad Edge 15", ALC269_FIXUP_SKU_IGNORE), > SND_PCI_QUIRK(0x17aa, 0x21f6, "Thinkpad T530", ALC269_FIXUP_LENOVO_DOCK), > + SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK), > SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_QUANTA_MUTE), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Lenovo Ideapd", ALC269_FIXUP_PCM_44K), > -- > 1.7.9.5 >