From: Takashi Iwai Subject: Re: [PATCH 2/2] drm/i915: Add lvds_channel module option Date: Sat, 17 Mar 2012 09:00:25 +0100 Message-ID: References: <1331934073-24463-1-git-send-email-tiwai@suse.de> <1331934073-24463-3-git-send-email-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 832109E830 for ; Sat, 17 Mar 2012 01:00:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org, hcb@chaoticmind.net List-Id: intel-gfx@lists.freedesktop.org At Fri, 16 Mar 2012 22:51:22 -0300, Eugeni Dodonov wrote: > > [1 ] > On Fri, Mar 16, 2012 at 18:41, Takashi Iwai wrote: > > > Add a new module optoin lvds_channel to specify the LVDS channel mode > > explicitly instead of probing the LVDS register value set by BIOS. > > This will be helpful when VBT is broken or incompatible with the > > current code. > > > > Signed-off-by: Takashi Iwai > > --- > > drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ > > drivers/gpu/drm/i915/i915_drv.h | 1 + > > drivers/gpu/drm/i915/intel_display.c | 5 +++++ > > 3 files changed, 12 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c > > index 308f819..eee6804 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -80,6 +80,12 @@ MODULE_PARM_DESC(lvds_downclock, > > "Use panel (LVDS/eDP) downclocking for power savings " > > "(default: false)"); > > > > +int i915_lvds_channel __read_mostly; > > +module_param_named(lvds_channel, i915_lvds_channel, int, 0400); > > > > As a minor bikeshedding, perhaps this variable would make more sense if > called 'i915_lvds_channel_mode' instead? > > I am fine with either spelling though, it just looks more semantically > correct to me. But in any case, OK, I'll fix in the next spin. thanks, Takashi > > Reviewed-by: Eugeni Dodonov > > -- > Eugeni Dodonov > > [2 ] >