From: Takashi Iwai Subject: Re: [PATCH v2] ASoC: DAPM - Use dev_warn for debugfs warning message. Date: Wed, 07 Mar 2012 13:59:59 +0100 Message-ID: References: <1331057605-4542-1-git-send-email-lrg@ti.com> <20120306200810.GC19635@opensource.wolfsonmicro.com> <1331113730.3829.7.camel@odin> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id F29352413B for ; Wed, 7 Mar 2012 14:00:02 +0100 (CET) In-Reply-To: <1331113730.3829.7.camel@odin> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org At Wed, 07 Mar 2012 09:48:50 +0000, Liam Girdwood wrote: > > On Tue, 2012-03-06 at 20:08 +0000, Mark Brown wrote: > > On Tue, Mar 06, 2012 at 06:13:25PM +0000, Liam Girdwood wrote: > > > Remove printk(KERN_WARNING) and use dev_warn() instead. > > > > Applied, thanks. > > > > Everyone else seems to be doing ASoC: thing: rather than having a -. As > > far as I remember it was Peter that started it, though other people > > (including me) adopted it too. > > Historically since 2005 the ASoC patch subject prefix has never been in > any fixed style. My personal preference is the same as Takashi's for > HDA, but I've no problems changing a - to a :. Lets make it more > official now and have :- > > ASoC: thing: change It seems that "A: B: C" is more popular, indeed. I've been using it since it looks more readable to me, but it's really a matter of taste. Takashi