From: Takashi Iwai Subject: Re: [PATCH 3/3] ALSA: Build jack detection Date: Mon, 28 Jul 2008 15:05:46 +0200 Message-ID: References: <20080727111107.GA6667@sirena.org.uk> <1217157145-7647-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1217157145-7647-2-git-send-email-broonie@opensource.wolfsonmicro.com> <1217157145-7647-3-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A5E54103805 for ; Mon, 28 Jul 2008 15:05:46 +0200 (CEST) In-Reply-To: <1217157145-7647-3-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 27 Jul 2008 12:12:25 +0100, Mark Brown wrote: > > Since jack detection requires the input subsystem which may not be > desired on small systems it is not built unless required by a driver > that is being built. Drivers using jack detection should use a pattern > like this: > > config SND_FOO > tristate "..." > ... > select SND_JACK if INPUT=y || INPUT=SND > > to ensure that the jack detection API is enabled if the input subsystem > is. If the input subsystem is not enabled then a stub version of the > API is provided. Would be nice to put this as a comment in sound/core/Kconfig. thanks, Takashi