From: Takashi Iwai Subject: Re: [PATCH] dapm_new_mixer and 32 bytes limitation Date: Mon, 21 Jan 2008 12:16:21 +0100 Message-ID: References: <87r6geevtb.fsf@polgara.paysbobval> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns1.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id F355E24369 for ; Mon, 21 Jan 2008 12:16:21 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jaroslav Kysela Cc: Robert Jarzmik , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 21 Jan 2008 12:05:55 +0100 (CET), Jaroslav Kysela wrote: > > On Mon, 21 Jan 2008, Takashi Iwai wrote: > > > At 18 Jan 2008 21:13:36 +0100, > > Robert Jarzmik wrote: > > > > > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > > > index ea20138..f22a1bb 100644 > > > --- a/sound/soc/soc-dapm.c > > > +++ b/sound/soc/soc-dapm.c > > > @@ -281,7 +281,7 @@ static int dapm_new_mixer(struct snd_soc_codec *codec, > > > struct snd_soc_dapm_widget *w) > > > { > > > int i, ret = 0; > > > - char name[32]; > > > + char name[44]; > > > > Let's add a global const in asound.h instead of using a magic number > > everywhere. > > What about this: > > int namelen = sizeof(w->kcontrols[0].name); I thought of it, too, but it's too ugly, I'd say. Takashi