Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F183FC433F5 for ; Tue, 25 Jan 2022 14:15:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CC6012066; Tue, 25 Jan 2022 15:14:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CC6012066 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1643120113; bh=5D44eq4f1KHY2SHcZFS4L8CG4NtW7sbeNZS183YD5Dw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=S6UNVtM3hHpQHiHi8A02dMHnFnV6hxxPcXtOaDq6okevU12wJziz7ER43Dl92Aq6k hweht+x328CVlnSLgDN5HhqkNvxPBkTgxttDHTCUNQq9z/VxU3k1yPkSGkJceNbc3Z IgNHzL+58a94IP5S5b3v6QvHV3CIsKaFK/hSGgyk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7581EF80161; Tue, 25 Jan 2022 15:14:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 378F3F804C3; Tue, 25 Jan 2022 15:14:22 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 00751F80161 for ; Tue, 25 Jan 2022 15:14:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 00751F80161 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LvmiRU6J"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BbLbKuML" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 36FA8210E2; Tue, 25 Jan 2022 14:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643120055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EPufQYCfjk0CmwsqlRmnaqd3XhXd7OMY3GxDqpQUduU=; b=LvmiRU6JEm4Fk2IdB/JDzmWRQngUKQskUAP6FIA7GjJYfBSZyBxLUmrSniXCEwKnPR6PFq 1vga6tQiM6V+BQvrN/n63fkAnjzsp/oBbrcKyg1JDP0I0xrBuDUh4nq71H2ewpgvxBLP6R /U4TCtqUNVgFQ42LqL5hYjz5ZCpCXhQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643120055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EPufQYCfjk0CmwsqlRmnaqd3XhXd7OMY3GxDqpQUduU=; b=BbLbKuML6yb02kPW7w53iLZ6pyHW2UApDvbuFOWUVWRybqaSR//jP0AiC1KYcYAs2XOF5d 5klJfS9hlFD46sBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 23A37A3B8E; Tue, 25 Jan 2022 14:14:15 +0000 (UTC) Date: Tue, 25 Jan 2022 15:14:15 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Subject: Re: [PATCH] kselftest: alsa: Add test case for writing invalid values In-Reply-To: <20220124151410.2715572-1-broonie@kernel.org> References: <20220124151410.2715572-1-broonie@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Shuah Khan , Takashi Iwai , linux-kselftest@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 24 Jan 2022 16:14:10 +0100, Mark Brown wrote: > +bool test_ctl_write_invalid_integer64(struct ctl_data *ctl) > +{ .... > + /* Minimum representable value */ > + snd_ctl_elem_value_copy(val, ctl->def_val); > + snd_ctl_elem_value_set_integer(val, i, LLONG_MIN); This should be snd_ctl_elem_value_set_integer64()? > + /* Maximum representable value */ > + snd_ctl_elem_value_copy(val, ctl->def_val); > + snd_ctl_elem_value_set_integer(val, i, LLONG_MAX); Ditto. thanks, Takashi