Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82275C433DF for ; Fri, 9 Oct 2020 14:45:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CDB822260 for ; Fri, 9 Oct 2020 14:45:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j0Px36Jf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CDB822260 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F1A0D15F2; Fri, 9 Oct 2020 16:44:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F1A0D15F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602254741; bh=ELi+elNZCtCI963bjntnjMQSyXtEqna/I3PQPiGlwDA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j0Px36Jf/GOt+CXmrdeOAz9beklKZfQExj6d1H1KN1c6ZYFQhQyHa6cJ4PtDtDbQb nroxeARIyoYBxZa3ZS8RVPdy3zNAgOsr0lfj5Eps1GVGMYZsP9CXU0pMogEWvAI3Lh ZYGW5fMkYl5mkibgYvN2zbAL5UpR+FgANB99DdKQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8AEA1F80148; Fri, 9 Oct 2020 16:44:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6FFB4F8015B; Fri, 9 Oct 2020 16:44:48 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41213F800BF for ; Fri, 9 Oct 2020 16:44:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41213F800BF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E543AD73; Fri, 9 Oct 2020 14:44:44 +0000 (UTC) Date: Fri, 09 Oct 2020 16:44:43 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH 1/1] ALSA: hda: fix jack detection with Realtek codecs when in D3 In-Reply-To: References: <20201009140227.691140-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kai-Heng Feng , Kailang Yang , Kai Vehmanen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 09 Oct 2020 16:38:05 +0200, Pierre-Louis Bossart wrote: > > > > On 10/9/20 9:02 AM, Kai Vehmanen wrote: > > In case HDA controller is active, but codec is runtime suspended, jack > > detection is not successful and no interrupt is raised. This has been > > observed with multiple Realtek codecs and HDA controllers from different > > vendors. Bug does not occur if both codec and controller are active, > > or both are in suspend. Bug can be easily hit on desktop systems with > > no built-in speaker. > > > > The problem can be fixed by powering up the codec once after every > > controller runtime resume. Even if codec goes back to suspend, the jack > > detection will now work. Add a flag to 'hda_codec' to describe codecs > > that require this flow from the controller driver. Mark all Realtek > > codecs with this flag. > > It does make sense to request the codec to resume when the controller > resumes, we did the same for SoundWire IIRC. > > I am still confused on what happens if e.g. the controller resumes and > remains active, e.g. capturing from the DMIC. The codec would become > suspended after a while and then we would be back to the same problem, > wouldn't we? > > Or are you saying that this initial resume of the codec is enough? When the controller is active and the codec goes to runtime suspend, the codec will be woken up via the unsolicited event per jack change. So it seems that the problem is only about the wake up from the controller's runtime suspend. thanks, Takashi