From: Takashi Iwai Subject: Re: [PATCH 2/3] ALSA: aoa: Fix of-node refcount unbalance Date: Tue, 19 Feb 2019 16:57:41 +0100 Message-ID: References: <20190219153124.12595-1-tiwai@suse.de> <20190219153124.12595-3-tiwai@suse.de> <745519866a406b0ee1df34f03fc29e892f0fca0f.camel@sipsolutions.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6A626265535 for ; Tue, 19 Feb 2019 16:57:42 +0100 (CET) In-Reply-To: <745519866a406b0ee1df34f03fc29e892f0fca0f.camel@sipsolutions.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Johannes Berg Cc: alsa-devel@alsa-project.org, Robert Jarzmik List-Id: alsa-devel@alsa-project.org On Tue, 19 Feb 2019 16:50:00 +0100, Johannes Berg wrote: > > On Tue, 2019-02-19 at 16:31 +0100, Takashi Iwai wrote: > > We forgot to unreference a node obtained via of_find_node_by_name() > > after its usage. > > How did you find this now?! Though I guess something like smatch could > find it, or even coccinelle? I'm old-fashioned, just did manual reviews casually after the discussion about the recent regression regarding OF node refcount in an ASoC driver :) A coccinelle or such would be smarter, yeah :) > > Only compile-tested. Please review carefully. Thanks! > > Yes, looks right > > Reviewed-by: Johannes Berg > > I still have, but no longer run, the machine that uses this driver ... > anyone need a Powermac G5 quad? ;-) Let's seek for museums :) thanks, Takashi