From: Takashi Iwai Subject: Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range() Date: Fri, 27 Jul 2018 11:48:28 +0200 Message-ID: References: <20180727085528.5802-1-baijiaju1990@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180727085528.5802-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jia-Ju Bai Cc: kai.heng.feng@canonical.com, nob77413@gmail.com, ruslan.bilovol@gmail.com, perex@perex.cz, jussi@sonarnerd.net, elfring@users.sourceforge.net, daniel@zonque.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 27 Jul 2018 10:55:28 +0200, Jia-Ju Bai wrote: > > snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and > snd_usb_ctl_msg_quirk() are never called in atomic context. > They call mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep() and usleep_range(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied, thanks. Takashi