From: Takashi Iwai Subject: Re: [PATCH] hda: Added mono mux mixer for some STAC92HD7XXX family codecs Date: Mon, 21 Jan 2008 15:19:40 +0100 Message-ID: References: <47911DCA.9070104@embeddedalley.com> <4794A51C.6070709@embeddedalley.com> <4794A8C2.2090300@embeddedalley.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6764B24367 for ; Mon, 21 Jan 2008 15:19:40 +0100 (CET) In-Reply-To: <4794A8C2.2090300@embeddedalley.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Matthew Ranostay Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 21 Jan 2008 09:14:26 -0500, Matthew Ranostay wrote: > > Takashi Iwai wrote: > > At Mon, 21 Jan 2008 08:58:52 -0500, > > Matthew Ranostay wrote: > >> Takashi Iwai wrote: > >>> At Fri, 18 Jan 2008 16:44:42 -0500, > >>> Matthew Ranostay wrote: > >>>> Some 92HD7XXX family codecs have a mono mux, added support for selecting the input path to the mono out. > >>>> > >>>> Signed-off-by: Matthew Ranostay > >>> Could you fix the coding-style issues reported by checkpatch.pl? > >> Ok, fixed the 80-character lines it complained about, although I left the 'declaration in if statement' since > >> the code block below it does the same style. > > > > Well, apprently you didn't run checkpatch.pl to the new patch? ;) > > > > ERROR: do not use assignment in if condition (+ if ((err = stac92xx_auto_create_mono_output_ctls(codec)) < 0)) > > #224: FILE: pci/hda/patch_sigmatel.c:2609: > > + if ((err = stac92xx_auto_create_mono_output_ctls(codec)) < 0) > > > I did but I didn't change it because the line below it does the same coding style. > But in that case I'll change both :) Do it only for your own part at first. Then let's clean up the whole file later so that we can separate changes, one for a bug fix, and one for trivial coding style fixes. thanks, Takashi