From: Takashi Iwai Subject: Re: [PATCH] alsa-driver: portman2x4 code cleanup Date: Wed, 24 Jan 2007 18:00:58 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 7322B2FF for ; Wed, 24 Jan 2007 18:00:59 +0100 (MET) Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id EF67E122AC for ; Wed, 24 Jan 2007 18:00:58 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Matthias Koenig Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 24 Jan 2007 16:28:09 +0100, Matthias Koenig wrote: > > Hi, > > here is the long announced cleanup of the portman2x4 driver code, > please review. > > Thanks, > Matthias > > Signed-off-by: Matthias Koenig > ============================================================ > Summary: portman2x4 code cleanup > > - changed code structure to mirror the one of the mts64.c driver > for better maintenance > - added proper handling of platform device > - general cleanup (no CamelCase names) Thanks, the changes look good to me. Since the patch couldn't be applied cleanly, I fixed it manually. Also, added cpu_relax() in busy loops, and fixed unneeded initialization of variables. The code is now committed to ALSA HG tree. Please give it a try. BTW, if the driver works for you, we can move this to alsa-kernel tree so that it's merged to the upstream kernel... Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV