Message-ID: <sashiko-outbox-204552@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH 2/4] crypto: engine - add acomp support
Reply-To: sashiko-reviews@lists.linux.dev
To: "Chenghai Huang" <huangchenghai2@huawei.com>, herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, liulongfang@huawei.com, qianweili@huawei.com, wangzhou1@hisilicon.com, linwenkai6@hisilicon.com
In-Reply-To: <20261109073556.2517351-3-huangchenghai2@huawei.com>
References: <20261109073556.2517351-1-huangchenghai2@huawei.com>
 <20261109073556.2517351-3-huangchenghai2@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Mon, 09 Nov 2026 07:46:49 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] crypto: engine - missing CRYPTO_ACOMP select in CRYPTO_ENGINE
  Kconfig
--

commit 21d47c711df84337042460c8075ae29a58a54c22
Author: Chenghai Huang <huangchenghai2@huawei.com>

crypto: engine - add acomp support

This commit adds asynchronous compression (acomp) request transfer,
finalization, and algorithm registration helpers to the crypto engine
framework, and moves struct acomp_alg to include/crypto/acompress.h.

> diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c
> index 5b669038acb45..2a0740d9dd634 100644
> --- a/crypto/crypto_engine.c
> +++ b/crypto/crypto_engine.c
[ ... ]
> @@ -504,6 +532,20 @@ void crypto_engine_exit(struct crypto_engine *engine)
>  }
>  EXPORT_SYMBOL_GPL(crypto_engine_exit);
> =20
> +int crypto_engine_register_acomp(struct acomp_engine_alg *alg)
> +{
> +	if (!alg->op.do_one_request)
> +		return -EINVAL;
> +	return crypto_register_acomp(&alg->base);
> +}
> +EXPORT_SYMBOL_GPL(crypto_engine_register_acomp);
> +
> +void crypto_engine_unregister_acomp(struct acomp_engine_alg *alg)
> +{
> +	crypto_unregister_acomp(&alg->base);
> +}
> +EXPORT_SYMBOL_GPL(crypto_engine_unregister_acomp);
> +
>  int crypto_engine_register_aead(struct aead_engine_alg *alg)
>  {
>  	if (!alg->op.do_one_request)

[Severity: High]
Does CRYPTO_ENGINE in crypto/Kconfig also need to select CRYPTO_ACOMP?

crypto_register_acomp() and crypto_unregister_acomp() are only built when
CONFIG_CRYPTO_ACOMP2 is enabled, and have no inline stub fallbacks.
Unlike CRYPTO_AEAD, CRYPTO_AKCIPHER, CRYPTO_HASH, CRYPTO_KPP, and
CRYPTO_SKCIPHER, CRYPTO_ENGINE does not select CRYPTO_ACOMP, so enabling
CONFIG_CRYPTO_ENGINE without CONFIG_CRYPTO_ACOMP2 (or with
CONFIG_CRYPTO_ENGINE=3Dy and CONFIG_CRYPTO_ACOMP2=3Dm) fails to link with
undefined references to crypto_register_acomp() and
crypto_unregister_acomp().

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261109073556.2517=
351-1-huangchenghai2@huawei.com?part=3D2