Message-ID: <sashiko-outbox-206350@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH] crypto: sun8i-ce - Add AES-XTS for the H616
Reply-To: sashiko-reviews@lists.linux.dev
To: "Arun Iyengar" <aiyengar1990@gmail.com>, "Corentin Labbe" <clabbe.montjoie@gmail.com>, "Herbert
 Xu" <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, "Chen-Yu
 Tsai" <wens@kernel.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Samuel
 Holland" <samuel@sholland.org>
Cc: linux-crypto@vger.kernel.org, linux-sunxi@lists.linux.dev
In-Reply-To: <20261110-sun8i-ce-h616-xts-v1-1-2fff3eb0807a@gmail.com>
References: <20261110-sun8i-ce-h616-xts-v1-1-2fff3eb0807a@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Nov 2026 05:53:44 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] crypto: sun8i-ce: missing CRYPTO_XTS select fails
  sun8i_ce_cipher_init()
--

commit 660524c38c775c4edff2e13f8df35a02b4667a78
Author: Arun Iyengar <aiyengar1990@gmail.com>

crypto: sun8i-ce - Add AES-XTS for the H616

This commit adds AES-XTS support for the Allwinner H616 crypto engine
using its RAES unit and registers xts-aes-sun8i-ce with a fallback
transform.

> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/=
crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> index 21762bd408e54..a7d771927b7a1 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c

[ ... ]

> @@ -350,6 +350,36 @@ static struct sun8i_ce_alg_template ce_algs[] =3D {
>  		.do_one_request =3D sun8i_ce_cipher_do_one,
>  	},
>  },
> +{
> +	.type =3D CRYPTO_ALG_TYPE_SKCIPHER,
> +	.ce_algo_id =3D CE_ID_CIPHER_AES,
> +	.ce_blockmode =3D CE_ID_OP_XTS,
> +	.alg.skcipher.base =3D {
> +		.base =3D {
> +			.cra_name =3D "xts(aes)",
> +			.cra_driver_name =3D "xts-aes-sun8i-ce",
> +			.cra_priority =3D CE_PRIO_BELOW_CPU,
> +			.cra_blocksize =3D AES_BLOCK_SIZE,
> +			.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER |
> +				CRYPTO_ALG_ASYNC |
> +				CRYPTO_ALG_NEED_FALLBACK,
> +			.cra_ctxsize =3D sizeof(struct sun8i_cipher_tfm_ctx),
> +			.cra_module =3D THIS_MODULE,
> +			.cra_alignmask =3D 0xf,
> +			.cra_init =3D sun8i_ce_cipher_init,

[Severity: Medium]
Should CRYPTO_DEV_SUN8I_CE in drivers/crypto/allwinner/Kconfig select
CRYPTO_XTS alongside CRYPTO_ECB and CRYPTO_CBC?

sun8i_ce_cipher_init() unconditionally calls
crypto_alloc_skcipher("xts(aes)", 0, CRYPTO_ALG_NEED_FALLBACK) to allocate
op->fallback_tfm, which fails with -ENOENT during registration self-tests
or transform allocation when CONFIG_CRYPTO_XTS is disabled and no other
xts(aes) implementation is built in.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110-sun8i-ce-h=
616-xts-v1-1-2fff3eb0807a@gmail.com?part=3D1