Message-ID: <sashiko-outbox-207022@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH printk 1/6] printk: Introduce and specify flush reasons
Reply-To: sashiko-reviews@lists.linux.dev
To: "John Ogness" <john.ogness@linutronix.de>, "Petr Mladek" <pmladek@suse.com>
Cc: "Sergey Senozhatsky" <senozhatsky@chromium.org>, "Steven Rostedt" <rostedt@goodmis.org>, "Ryan
 Roberts" <ryan.roberts@arm.com>, "Breno Leitao" <leitao@debian.org>, printk@lists.linux.dev, "Madhavan
 Srinivasan" <maddy@linux.ibm.com>, "Michael Ellerman" <mpe@ellerman.id.au>, "Nicholas
 Piggin" <npiggin@gmail.com>, =?utf-8?b?Q2hyaXN0b3BoZSBMZXJveSAoQ1MgR1JP?=
 =?utf-8?b?VVAp?= <chleroy@kernel.org>, =?utf-8?b?Uml0ZXNoIEhhcmphbmkg?=
 =?utf-8?b?KElCTSk=?= <ritesh.list@gmail.com>, "Shrikanth Hegde" <sshegde@linux.ibm.com>, "Andrew
 Morton" <akpm@linux-foundation.org>, "Feng Tang" <feng.tang@linux.alibaba.com>, "Jinjie
 Ruan" <ruanjinjie@huawei.com>, "Mukesh Kumar Chaurasiya" <mchauras@linux.ibm.com>, "Oleg
 Nesterov" <oleg@redhat.com>, "Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>, "Bradley
 Morgan" <include@grrlz.net>, =?utf-8?b?Q2hyaXN0aWFuIEJyYXVuZXIgKEFtdXRh?=
 =?utf-8?b?YmxlKQ==?= <brauner@kernel.org>, =?utf-8?b?Q2VuIFpoYW5nIChN?=
 =?utf-8?b?aWNyb3NvZnQp?= <blbllhy@gmail.com>, "Petr Pavlu" <petr.pavlu@suse.com>
In-Reply-To: <20261109123127.489676-2-john.ogness@linutronix.de>
References: <20261109123127.489676-1-john.ogness@linutronix.de>
 <20261109123127.489676-2-john.ogness@linutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Nov 2026 12:31:40 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] printk: missing @reason kernel-doc description for
  printk_trigger_flush()
--

commit 2671602433b21536db216fd234b44b9f5ac6b234
Author: John Ogness <john.ogness@linutronix.de>

printk: Introduce and specify flush reasons

This commit introduces enum pr_flush_reason and propagates it from
printk_trigger_flush() and atomic flush callers down to
__nbcon_atomic_flush_pending_con().

> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 5dbcf8a9909bb..ab9f2d6a6526a 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
[ ... ]
> @@ -4732,13 +4732,13 @@ void defer_console_output(void)
>   * This is best effort. Depending on the system state, console states,
>   * and caller context, no actual flushing may result from this call.
>   */
> -void printk_trigger_flush(void)
> +void printk_trigger_flush(enum pr_flush_reason reason)

[Severity: Low]
Should the kernel-doc comment above printk_trigger_flush() also document
@reason to avoid a W=3D1 kernel-doc warning?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261109123127.4896=
76-1-john.ogness@linutronix.de?part=3D1