Message-ID: <sashiko-outbox-207200@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2 2/2] mfd: mxs-lradc: Pass parent IRQs to child
 drivers
Reply-To: sashiko-reviews@lists.linux.dev
To: "Fabio Estevam" <festevam@gmail.com>
Cc: linux-input@vger.kernel.org, mfd@lists.linux.dev, devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, dmitry.torokhov@gmail.com, lee@kernel.org
In-Reply-To: <20261110141934.42490-2-festevam@gmail.com>
References: <20261110141934.42490-1-festevam@gmail.com>
 <20261110141934.42490-2-festevam@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Nov 2026 14:38:06 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mfd: mxs-lradc: Fixes trailer cites driver-core warning commit
--

commit fbb3c430756f909de04d8f2ea7a88e5473612cd3
Author: Fabio Estevam <festevam@gmail.com>

> mfd: mxs-lradc: Pass parent IRQs to child drivers
>=20
> The MFD driver stores raw DT interrupt indices in IRQ resources but
> registers its child devices without an IRQ domain or IRQ base. The child
> drivers consequently receive the indices as if they were mapped Linux
> IRQ numbers. IRQ index 0 triggers the platform_get_irq_byname() warning:
>=20
>   0 is an invalid IRQ number
>=20
> The children then try to recover the indices from their resources and
> map them against the parent OF node. Besides duplicating IRQ names in
> the parent and children, this relies on invalid platform IRQ resources
> and fails when IRQ 0 is rejected.
>=20
> Resolve the interrupts with platform_get_irq() in the MFD parent and
> store the mapped IRQs in the shared LRADC data. Drop the child IRQ
> resources and duplicated name arrays, and have both child drivers
> request the mapped IRQs directly. Use the MFD memory base support to
> translate a single relative memory resource shared by both cells.
>=20
> Tested on an i.MX28 EVK. The mxs-lradc-ts driver probes successfully,
> touch events are reported, and the touch-detect and LRADC channel 7
> interrupt counters increase as expected.
>=20
> Cc: stable@vger.kernel.org
> Suggested-by: Lee Jones <lee@kernel.org>
> Closes: https://lore.kernel.org/linux-input/CAOMZO5CgTzo6GuXptD4mFTN=3DUs=
JJqpkixDW1Q64gqZGrij8+uQ@mail.gmail.com/
> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invali=
d")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

[Severity: Low]
Commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is
invalid") only added a warning in the platform driver core when an
IORESOURCE_IRQ resource has start =3D=3D 0.  The unmapped DT interrupt indi=
ces
in the MFD cell resources and the irq_of_parse_and_map() workaround in the
child drivers were introduced when the driver was split in ead25133e935
("mfd: mxs-lradc: Add support for mxs-lradc"), 6dd112b9f85e ("iio: adc:
mxs-lradc: Add support for ADC driver"), and d81ca730e3e4 ("input:
touchscreen: mxs-lradc: Add support for touchscreen").

Should the Fixes: tag reference those commits instead?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110141934.4249=
0-1-festevam@gmail.com?part=3D2