Message-ID: <sashiko-outbox-207309@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2 12/28] drm/panthor: Add AM_SYSTEM platform driver
To: "Karunika Choo" <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
In-Reply-To: <20261110153907.3241978-13-karunika.choo@arm.com>
References: <20261110153907.3241978-1-karunika.choo@arm.com>
 <20261110153907.3241978-13-karunika.choo@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Nov 2026 15:57:32 +0000
Precedence: list
Reply-To: sashiko-reviews@lists.linux.dev
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panthor: undocumented gpu-supply in
  panthor_system_regulator_init()
--

commit 7d8058a58397fcb291163cb1ac726e2a1ba1d037
Author: Karunika Choo <karunika.choo@arm.com>

drm/panthor: Add AM_SYSTEM platform driver

This commit adds the AM_SYSTEM platform driver for Arm Mali 5th Gen AM GPUs
to manage shared clock and regulator resources and perform the initial GPU
reset sequence during probe.

> diff --git a/drivers/gpu/drm/panthor/system/panthor_system_drv.c b/driver=
s/gpu/drm/panthor/system/panthor_system_drv.c
> new file mode 100644
> index 0000000000000..e70dba4058f38
> --- /dev/null
> +++ b/drivers/gpu/drm/panthor/system/panthor_system_drv.c
> @@ -0,0 +1,344 @@
[ ... ]
> +static int panthor_system_regulator_init(struct panthor_system *sdev)
> +{
> +	struct regulator *regulator =3D NULL;
> +	int ret;
> +
> +	regulator =3D devm_regulator_get_optional(sdev->dev, "gpu");
> +	if (IS_ERR(regulator)) {
> +		ret =3D PTR_ERR(regulator);
> +
> +		/* Regulator not found. Exit */
> +		if (ret =3D=3D -ENODEV)
> +			return 0;
> +
> +		return dev_err_probe(sdev->dev, ret, "Failed to get gpu-supply");
> +	}

[Severity: Low]
Should gpu-supply be documented in
Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-system.yaml?  That
schema sets additionalProperties: false without listing gpu-supply, so any
arm,mali-gen5-am-system device tree node providing the regulator expected
here will fail dtbs_check validation.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110153907.3241=
978-1-karunika.choo@arm.com?part=3D12