Message-ID: <sashiko-outbox-207359@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2 28/28] drm/panthor: Reset partitions before starting
 arbitration
To: "Karunika Choo" <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
In-Reply-To: <20261110153907.3241978-29-karunika.choo@arm.com>
References: <20261110153907.3241978-1-karunika.choo@arm.com>
 <20261110153907.3241978-29-karunika.choo@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Nov 2026 16:22:52 +0000
Precedence: list
Reply-To: sashiko-reviews@lists.linux.dev
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/panthor: adev->pc[i] left set on partition_ensure_reset()
  failure
--

commit 872e2f2e631e5b4428bb12ac09aefb750b611c43
Author: Karunika Choo <karunika.choo@arm.com>

drm/panthor: Reset partitions before starting arbitration

This commit ensures each partition is brought into the RESET state with
interrupts masked during partition control initialization before starting
arbitration.

> diff --git a/drivers/gpu/drm/panthor/arbitration/panthor_partition_contro=
l.c b/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c
> index 3b472403f49d1..2c0f8dc0b3bfb 100644
> --- a/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c
> +++ b/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c
[ ... ]
> @@ -429,6 +479,10 @@ static int partition_control_init(struct panthor_arb=
itration *adev, int i)
> =20
>  	adev->pc[i] =3D pc;
> =20
> +	ret =3D partition_ensure_reset(pc);
> +	if (ret)
> +		return ret;

[Severity: Medium]
Should adev->pc[i] be assigned only after partition_ensure_reset()
succeeds?

When partition_ensure_reset() fails, panthor_arbitration_probe() unwinds
via panthor_partition_control_term(), which iterates over non-NULL
adev->pc[i] entries and runs window_close() and partition_state_wait() on
the partition that just failed reset recovery, triggering WARN_ON() and
an extra 5-second timeout.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110153907.3241=
978-1-karunika.choo@arm.com?part=3D28