Message-ID: <sashiko-outbox-208018@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2 7/9] HID: Add hid-plugin framework for loadable
 plugin modules
Reply-To: sashiko-reviews@lists.linux.dev
To: "Rong Zhang" <i@rong.moe>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
In-Reply-To: <20261110-hid-haptic-kmod-v2-7-b835a067cb62@rong.moe>
References: <20261110-hid-haptic-kmod-v2-0-b835a067cb62@rong.moe>
 <20261110-hid-haptic-kmod-v2-7-b835a067cb62@rong.moe>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 00:25:56 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: hid-plugin: missing Return section in hid_plugin_register()
  kernel-doc
--

commit ea30651fd5d31e4684e4f118c37b9199cf1158fc
Author: Rong Zhang <i@rong.moe>

HID: Add hid-plugin framework for loadable plugin modules

This commit introduces a hid-plugin framework that allows HID drivers to
request optional loadable or builtin plugin modules via RCU and module
reference counting.

Link: https://lore.kernel.org/linux-input/auypydfkhx2eg7vp764way4batdilzc35=
inqda3exwzs3tk3ff@oagat6g46zto/

> diff --git a/drivers/hid/hid-plugin.h b/drivers/hid/hid-plugin.h
> new file mode 100644
> index 0000000000000..4038325c51a08
> --- /dev/null
> +++ b/drivers/hid/hid-plugin.h

[ ... ]

> +/**
> + * hid_plugin_register() - Register an HID plugin.
> + * @id: Unique ID of @plugin
> + * @plugin: Pointer to the HID plugin
> + */
> +static __always_inline int hid_plugin_register(enum hid_plugin_id id, st=
ruct hid_plugin *plugin)
> +{
> +	BUILD_BUG_ON(!hid_plugin_enabled(id));
> +
> +	return __hid_plugin_register(id, plugin);
> +}

[Severity: Low]
The kernel-doc comment for hid_plugin_register() omits a Return: section,
which causes a kernel-doc warning when building with W=3D1.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110-hid-haptic=
-kmod-v2-0-b835a067cb62@rong.moe?part=3D7