Message-ID: <sashiko-outbox-208030@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2 9/9] HID: haptic: Remove stubs in favor of inlined
 dead code elimination
Reply-To: sashiko-reviews@lists.linux.dev
To: "Rong Zhang" <i@rong.moe>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
In-Reply-To: <20261110-hid-haptic-kmod-v2-9-b835a067cb62@rong.moe>
References: <20261110-hid-haptic-kmod-v2-0-b835a067cb62@rong.moe>
 <20261110-hid-haptic-kmod-v2-9-b835a067cb62@rong.moe>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 00:45:18 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] HID: haptic: hid_haptic_connected_to_input() returns ERR_PTR
  instead of false
--

commit 3914d83f5b9ce7ec32449543dd125ffa8f399224
Author: Rong Zhang <i@rong.moe>

HID: haptic: Remove stubs in favor of inlined dead code elimination

This commit removes the #else stub implementations in
drivers/hid/hid-haptic.h and replaces them with hid_haptic_enabled()
checks inside the inline helpers.

> diff --git a/drivers/hid/hid-haptic.h b/drivers/hid/hid-haptic.h
> index a71ccee569f31..070b56189ccbe 100644
> --- a/drivers/hid/hid-haptic.h
> +++ b/drivers/hid/hid-haptic.h

[ ... ]

> @@ -80,6 +87,9 @@ static inline struct hid_haptic_device *hid_haptic_allo=
c(struct hid_device *hdev
>  static inline bool hid_haptic_connected_to_input(struct hid_haptic_devic=
e *haptic,
>  						 struct input_dev *input)
>  {
> +	if (!hid_haptic_enabled())
> +		return ERR_PTR(-EOPNOTSUPP);
> +
>  	return haptic->input_dev =3D=3D input;
>  }

[Severity: Medium]
Should hid_haptic_connected_to_input() return false instead of
ERR_PTR(-EOPNOTSUPP) when !hid_haptic_enabled()?  Because the return type
is bool, the non-NULL error pointer converts to true, inverting the return
value of the removed stub and preventing dead-code elimination in callers
such as mt_touch_input_configured().

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110-hid-haptic=
-kmod-v2-0-b835a067cb62@rong.moe?part=3D9