Message-ID: <sashiko-outbox-208298@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: ufs: qcom: classify sm8150-ufshc as
 standalone ICE
Reply-To: sashiko-reviews@lists.linux.dev
To: "Andrew Gigena" <mail@andrewgigena.dev>, "Abel Vesa" <abelvesa@kernel.org>, "Herbert
 Xu" <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, "Rob
 Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor
 Dooley" <conor+dt@kernel.org>, "Manivannan Sadhasivam" <mani@kernel.org>, "Alim
 Akhtar" <alim.akhtar@samsung.com>, "Bart Van Assche" <bvanassche@acm.org>, "Bean
 Huo" <beanhuo@micron.com>, "Stanley Jhu" <stanleyjhu@google.com>, "Bjorn
 Andersson" <andersson@kernel.org>, "Andy Gross" <agross@kernel.org>, "Konrad
 Dybcio" <konradybcio@kernel.org>
Cc: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-scsi@vger.kernel.org
In-Reply-To: <20261111-sm8150-ice-rfc-v3-2-f9d5a806fc95@andrewgigena.dev>
References: <20261111-sm8150-ice-rfc-v3-0-f9d5a806fc95@andrewgigena.dev>
 <20261111-sm8150-ice-rfc-v3-2-f9d5a806fc95@andrewgigena.dev>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 04:35:22 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: ufs: qcom: moving sm8150-ufshc breaks existing
  2-reg/9-clock DTs
--

commit 830241ce50cfd60c40fb1ab69965eff9ecfda73c
Author: Andrew Gigena <mail@andrewgigena.dev>

dt-bindings: ufs: qcom: classify sm8150-ufshc as standalone ICE

This commit moves the qcom,sm8150-ufshc compatible from
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml to
Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml and updates
the example in qcom,ufs.yaml to use qcom,sdm845-ufshc.

> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml=
 b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> index 3c407426d6972..572eec814a604 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> @@ -23,6 +23,7 @@ select:
>            - qcom,sc7280-ufshc
>            - qcom,sc8180x-ufshc
>            - qcom,sc8280xp-ufshc
> +          - qcom,sm8150-ufshc
>            - qcom,sm8250-ufshc
>            - qcom,sm8350-ufshc
>            - qcom,sm8450-ufshc
> @@ -48,6 +49,7 @@ properties:
>                - qcom,sc7280-ufshc
>                - qcom,sc8180x-ufshc
>                - qcom,sc8280xp-ufshc
> +              - qcom,sm8150-ufshc
>                - qcom,sm8250-ufshc
>                - qcom,sm8350-ufshc
>                - qcom,sm8450-ufshc

[Severity: Medium]
As reported by Krzysztof Kozlowski on v2 [1], does moving
qcom,sm8150-ufshc to qcom,sc7180-ufshc.yaml break dtbs_check for existing
SM8150 and SA8155P device trees?

qcom,sc7180-ufshc.yaml restricts reg to maxItems: 1 and clocks to
maxItems: 8, rejecting the second ice register region and the ninth
ice_core_clk clock used by the embedded-ICE representation (supported
since 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")).
Later commit "arm64: dts: qcom: sm8150: use standalone ICE for UFS" in
this series converts the in-tree sm8150.dtsi to use a standalone ICE node,
but dtbs_check fails at this commit (and across subsystem trees if UFS
bindings and QCOM DTS changes are merged separately) and schema backwards
compatibility with existing 2-reg/9-clock DTBs is broken.

[1] https://lore.kernel.org/r/20261106-offbeat-hawk-of-purring-50a8aa@quoll

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111-sm8150-ice=
-rfc-v3-0-f9d5a806fc95@andrewgigena.dev?part=3D2