Message-ID: <sashiko-outbox-208329@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH] vhost/net: Fix receive queue test in busy poll
Reply-To: sashiko-reviews@lists.linux.dev
To: raoxu <raoxu@uniontech.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev, "Michael S. Tsirkin" <mst@redhat.com>, "Eugenio
 Perez" <eperezma@redhat.com>
In-Reply-To: <005FA5F7354482C7+20261110051642.249640-1-raoxu@uniontech.com>
References: <005FA5F7354482C7+20261110051642.249640-1-raoxu@uniontech.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 05:19:32 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] vhost/net: missing Fixes trailer for sock_has_rx_data() bug fix
--

commit e704f9e65e5ab760d5f0c63a3cc9fef9370b05b7
Author: Xu Rao <raoxu@uniontech.com>

> vhost/net: Fix receive queue test in busy poll
>
> sock_has_rx_data() returns a positive result when receive data is
> available. Socket implementations with a peek_len() callback follow
> that convention, but the fallback for sockets without one returns
> skb_queue_empty(), which has the opposite meaning.
>
> This makes busy polling stop when a raw packet socket has no queued data
> and fail to recognize queued data through the fallback path. Return the
> negated queue-empty result so the fallback matches the callback and its
> callers.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>

[Severity: Low]
The inverted skb_queue_empty() return value was introduced by
1576d9860599 ("tun: switch to use skb array for tx") and later moved to
sock_has_rx_data() by dc151282bbda ("net: vhost: factor out busy polling
logic to vhost_net_busy_poll()").  Should this include a Fixes tag, such
as:

  Fixes: 1576d9860599 ("tun: switch to use skb array for tx")

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/005FA5F7354482C7+20=
261110051642.249640-1-raoxu@uniontech.com?part=3D1