Message-ID: <sashiko-outbox-208631@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH 3/5] drm/amd/display: send the flip event right away if
 vblank is off
To: "Prike Liang" <Prike.Liang@amd.com>, dri-devel@lists.freedesktop.org
In-Reply-To: <20261111083534.514290-3-Prike.Liang@amd.com>
References: <20261111083534.514290-1-Prike.Liang@amd.com>
 <20261111083534.514290-3-Prike.Liang@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 08:45:48 +0000
Precedence: list
Reply-To: sashiko-reviews@lists.linux.dev
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/amd/display: missing Signed-off-by trailer in commit
  message
--

commit 26c603fc4a2cad18ac38e5e382079d6b467933c0
Author: Prike Liang <Prike.Liang@amd.com>

> drm/amd/display: send the flip event right away if vblank is off
>
> dm_arm_vblank_event_pre_programming() takes a vblank reference for a
> page flip or cursor update that carries an event, and the handler that
> later sends the event drops that reference again. The return value of
> drm_crtc_vblank_get() is ignored, though. If vblank is off, the event
> is armed anyway, and the handler that eventually sends it drops a
> reference that was never taken, which unbalances the vblank refcount.
>
> That can't happen today: DM only turns vblank off for a CRTC that it
> disables, and a disabled CRTC has no active planes. The next patch also
> turns vblank off while a GPU reset has the streams stopped, though.
> Page flips that don't modify the DC state skip
> amdgpu_dm_commit_streams() and only take dc_lock after this point, so
> they still get here while the reset holds it.
>
> Send the event right away when no vblank reference can be taken, like
> drm_crtc_vblank_off() does for queued vblank events. No vblank interrupt
> could deliver it in that case anyway.
>
> Add a KUnit test for it.
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Assisted-by: Copilot:claude-opus-5.5

[Severity: High]
This commit message is missing a Signed-off-by trailer from the patch
author.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111083534.5142=
90-1-Prike.Liang@amd.com?part=3D3