Message-ID: <sashiko-outbox-208776@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH RFC net-next v2 2/4] xdp: return status from
 generic_xdp_tx()
Reply-To: sashiko-reviews@lists.linux.dev
To: "Slawomir Stepien" <sst@poczta.fm>
Cc: bpf@vger.kernel.org
In-Reply-To: <20261110101941.1059662-3-sst@poczta.fm>
References: <20261110101941.1059662-1-sst@poczta.fm>
 <20261110101941.1059662-3-sst@poczta.fm>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 10:20:19 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bpf: multi-line comment style in xdp_do_generic_redirect()
--

commit 7706c10738f14b3774b96acd08e32f9887becd24
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

xdp: return status from generic_xdp_tx()

This commit changes generic_xdp_tx() to return 0 when the packet or all its
validated segments are handed to the driver, or a negative errno on failure,
while keeping xdp_do_generic_redirect() returning 0.

> diff --git a/net/core/filter.c b/net/core/filter.c
> index aca8160b26a1a..b7241cbfd8f13 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -4883,6 +4883,13 @@ int xdp_do_generic_redirect(struct net_device *dev=
, struct sk_buff *skb,
> =20
>  		skb->dev =3D fwd;
>  		_trace_xdp_redirect(dev, xdp_prog, ri->tgt_index);
> +		/* generic_xdp_tx() consumes the skb: either the driver took it,
> +		 * or the transmit failed and generic_xdp_tx() traced the drop,
> +		 * counted it in the target's tx_dropped and freed the skb.
> +		 * Returning its error would make our caller free the skb again,
> +		 * so report success, as native XDP does once a frame has been
> +		 * handed to the target device.
> +		 */
>  		generic_xdp_tx(skb, xdp_prog, XDP_REDIRECT);
>  		return 0;
>  	}

[Severity: Low]
This isn't a bug, but BPF coding style puts the opening /* of a multi-line
comment on its own line with the comment text starting on the next line.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110101941.1059=
662-1-sst@poczta.fm?part=3D2