Message-ID: <sashiko-outbox-208827@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub
 controller
Reply-To: sashiko-reviews@lists.linux.dev
To: "Fei Shao" <fshao@chromium.org>
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
In-Reply-To: <20261111103710.1393311-2-fshao@chromium.org>
References: <20261111103710.1393311-1-fshao@chromium.org>
 <20261111103710.1393311-2-fshao@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 10:44:49 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: usb: unwieldy per-compatible conditionals in
  genesys,gl850g.yaml
--

commit 74488a0f4f0a5f370e0fe57ea84abc8dcd904262
Author: Fei Shao <fshao@chromium.org>

dt-bindings: usb: Add Genesys Logic GL3525 hub controller

This commit adds the USB 3.2 (usb5e3,629) and USB 2.0 (usb5e3,630)
compatible strings for the Genesys Logic GL3525 hub controller to
genesys,gl850g.yaml.

> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/=
Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index e8b8c03f87a0e..5153a988a835e 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
[ ... ]
> @@ -70,6 +72,8 @@ allOf:
>              enum:
>                - usb5e3,610
>                - usb5e3,620
> +              - usb5e3,629
> +              - usb5e3,630
>      then:
>        properties:
>          peer-hub: true

[Severity: Low]
This isn't a bug, but the per-compatible if-then conditionals in allOf are
becoming unwieldy and inconsistent as more hub variants with different
supply and peer-hub rules are added to genesys,gl850g.yaml.

In particular, setting peer-hub: true and vdd-supply: true in the then
blocks is redundant because those properties are already defined at the top
level, usb5e3,626 is omitted from the conditionals entirely (leaving
vdd12-supply allowed on usb5e3,626 while disallowing it here), and
usb5e3,610 is restricted to vdd12-supply: false even when paired as the USB
2.0 companion hub for GL3590 (usb5e3,625).  Could these variants be split
into separate schema documents, or the conditionals simplified to only
restrict the properties that do not apply to specific compatibles?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111103710.1393=
311-1-fshao@chromium.org?part=3D1