Message-ID: <sashiko-outbox-208873@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH v2] dt-bindings: example-schema: Show example of
 dependentRequired
Reply-To: sashiko-reviews@lists.linux.dev
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
In-Reply-To: <20261111111403.83665-2-krzysztof.kozlowski@oss.qualcomm.com>
References: <20261111111403.83665-2-krzysztof.kozlowski@oss.qualcomm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 11:26:42 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: example-schema: duplicate dependencies and
  dependentRequired
--

commit 1be156d7b94f469cc7bb5216878b759c591f8b64
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: example-schema: Show example of dependentRequired

This commit adds a dependentRequired block to example-schema.yaml to
demonstrate conditional property requirements.

> diff --git a/Documentation/devicetree/bindings/example-schema.yaml b/Docu=
mentation/devicetree/bindings/example-schema.yaml
> index b04f3cc4312c0..a37d10ff7469a 100644
> --- a/Documentation/devicetree/bindings/example-schema.yaml
> +++ b/Documentation/devicetree/bindings/example-schema.yaml
> @@ -217,6 +217,14 @@ required:
>    - interrupts
>    - interrupt-controller
> =20
> +# Properties might be required only if some other property is present.
> +# dependentRequired is a shorter and preferred way to express this, inst=
ead of
> +# if:then: block.
> +dependentRequired:
> +  # clocks is not a required property in this binding, but if present, t=
hen
> +  # clock-names must be provided as well.
> +  clocks: [ clock-names ]
> +
>  # if/then schema can be used to handle conditions on a property affecting
>  # another property. A typical case is a specific 'compatible' value chan=
ges the
>  # constraints on other properties.

[Severity: Low]
Should this replace the existing dependencies block just above required
instead of adding a second section for the same construct?

example-schema.yaml already demonstrates conditional property presence under
the Draft-07 dependencies keyword (which is also referenced in the allOf
comment below), so keeping both leaves the example showing the legacy and
Draft 2019-09 keywords side by side.

Also, requiring clock-names whenever clocks is present conflicts with the
clocks and clock-names definitions earlier in this file, where clocks has
maxItems: 1 and the comment on clock-names advises skipping xxx-names for
single-entry lists.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111111403.8366=
5-2-krzysztof.kozlowski@oss.qualcomm.com?part=3D1