Message-ID: <sashiko-outbox-208894@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH 2/2] usbip: identify the event handler with
 current_work()
Reply-To: sashiko-reviews@lists.linux.dev
To: "Michael Grzeschik" <grzeschik@puzzle.ch>
Cc: linux-usb@vger.kernel.org
In-Reply-To: <20261111-usbip-v1-2-da5217ac71d7@puzzle.ch>
References: <20261111-usbip-v1-0-da5217ac71d7@puzzle.ch>
 <20261111-usbip-v1-2-da5217ac71d7@puzzle.ch>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 11:42:03 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usbip: missing Fixes: trailer for commit bb7871ad99ea
--

commit 823e2d0c8c9cae9400078a44aab5ee7919c0b1e1
Author: Michael Grzeschik <grzeschik@puzzle.ch>

> usbip: identify the event handler with current_work()
>
> usbip_in_eh() compares the task with worker_context, the first worker
> that ever ran the event handler. Workers of the unbound usbip_event
> workqueue are reaped when idle and new ones run the handler later, so the
> check fails inside the event handler, and the remembered task_struct may
> be reused by any other task, which then wrongly counts as the event
> handler. stub_disconnect() relies on it to skip the shutdown of a device
> reset from the event handler.
>
> Ask the workqueue which work item the current task executes instead.
>
> Signed-off-by: Michael Grzeschik <grzeschik@puzzle.ch>

[Severity: Low]
This fixes the worker_context check introduced when the event handler was
converted to a workqueue.  Should this include:

  Fixes: bb7871ad99ea ("usbip: event handler as one thread")

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111-usbip-v1-0=
-da5217ac71d7@puzzle.ch?part=3D2